From 65f487f1e87ca26eff5edc52eacd579189ea15d4 Mon Sep 17 00:00:00 2001
From: Evangelos Ribeiro Tzaras <devrtz@fortysixandtwo.eu>
Date: Tue, 19 Oct 2021 12:14:08 +0200
Subject: [PATCH] ci: Use strict metadata validation, but allow it to fail
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Validation will fail because the screenshots height is too large and not using a
16:9 aspect ratio:

• attribute-invalid     : <screenshot> height too large
  [https://gitlab.gnome.org/GNOME/calls/raw/master/data/screenshots/history.png]
  maximum is 900px

• aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9
  [https://gitlab.gnome.org/GNOME/calls/raw/master/data/screenshots/calling.png]

The strict validation will nevertheless provide valuable information.
---
 .gitlab-ci.yml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 9cf6215..9090e16 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -75,9 +75,10 @@ check-po:
     - cd po/
     - intltool-update -m 2>&1 | grep -qs '/.*\.c' && { intltool-update -m; exit 1; } || exit 0
 
-validate-metadata:
+validate-metadata-strict:
   stage: test
   image: debian:bookworm
+  allow_failure: true
   tags: []
   before_script:
     - export DEBIAN_FRONTEND=noninteractive
@@ -85,7 +86,7 @@ validate-metadata:
     - apt-get -y install eatmydata ca-certificates
     - eatmydata apt-get -y install appstream-util
   script:
-    - appstream-util validate data/org.gnome.Calls.metainfo.xml
+    - appstream-util validate-strict data/org.gnome.Calls.metainfo.xml
 
 package-debian-bookworm:
   tags: []