use RuntimeProvider in https (#1077)

* logger: missing https crate

* https: use RuntimeProvider when making connections

- [X] use RuntimeProvider when making TCP connections
- [ ] use RuntimeProvider when making TLS upgrades
- [ ] migrate tests

* RuntimeProvider::Tcp: remove async read/write

The TCP needs to Connect, the async readwriter will be in the
transport of connect. Thus we don't need it to be a requirement
on the top trait of RuntimeProvider

* AsyncResolver: remove async from new()

Related to overriding RuntimeProvider for #1074

Solves #1056

* cleanup tests

* rebase master for 0.19.5

* fix windows tests

Co-authored-by: Benjamin Fry <benjaminfry@me.com>
This commit is contained in:
Johnny Bergström
2020-05-02 20:18:50 +02:00
committed by GitHub
parent bc11ebd14e
commit 2502c58c14
20 changed files with 189 additions and 128 deletions

View File

@@ -116,7 +116,7 @@ pub async fn resolver(
config: config::ResolverConfig,
options: config::ResolverOpts,
) -> Result<AsyncStdResolver, ResolveError> {
AsyncStdResolver::new(config, options, AsyncStdRuntimeHandle).await
AsyncStdResolver::new(config, options, AsyncStdRuntimeHandle)
}
/// Constructs a new async-std based Resolver with the system configuration.
@@ -125,5 +125,5 @@ pub async fn resolver(
#[cfg(any(unix, target_os = "windows"))]
#[cfg(feature = "system-config")]
pub async fn resolver_from_system_conf() -> Result<AsyncStdResolver, ResolveError> {
AsyncStdResolver::from_system_conf(AsyncStdRuntimeHandle).await
AsyncStdResolver::from_system_conf(AsyncStdRuntimeHandle)
}

View File

@@ -68,7 +68,7 @@ fn test_ip_lookup_across_threads() {
use testing::ip_lookup_across_threads_test;
let io_loop = AsyncStdRuntime::new();
let handle = io_loop.handle();
ip_lookup_across_threads_test::<AsyncStdRuntime, AsyncStdRuntime>(io_loop, handle)
ip_lookup_across_threads_test::<AsyncStdRuntime, AsyncStdRuntime>(handle)
}
#[test]