colin/hickory-dns
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix initial vec capacity in NameServerConfigGroup::from_ips_clear

Browse Source 
Building a `NameServerConfigGroup` using `from_ips_clear` currently
always causes a reallocation of the underlying `Vec<NameServerConfig>`,
because two config entries are inserted per IP, while capacity is only
reserved for one.

This fix adds the missing `2 *` constant factor to `Vec::with_capacity`.
This commit is contained in:
Lyra Naeseth 2023-11-16 08:37:51 -08:00 committed by Dirkjan Ochtman
parent d07455476c
commit 2b1fe9e007
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crates/resolver/src/config.rs
View File

@ -568,11 +568,12 @@ impl NameServerConfigGroup {
///
/// This will create UDP and TCP connections, using the same port.
pub fn from_ips_clear(ips: &[IpAddr], port: u16, trust_negative_responses: bool) -> Self {
let mut name_servers = Self::with_capacity(ips.len());
let mut name_servers = Self::with_capacity(2 * ips.len());
for ip in ips {
let socket_addr = SocketAddr::new(*ip, port);
let udp = NameServerConfig {
socket_addr: SocketAddr::new(*ip, port),
socket_addr,
protocol: Protocol::Udp,
tls_dns_name: None,
trust_negative_responses,
@ -581,7 +582,7 @@ impl NameServerConfigGroup {
bind_addr: None,
};
let tcp = NameServerConfig {
socket_addr: SocketAddr::new(*ip, port),
socket_addr,
protocol: Protocol::Tcp,
tls_dns_name: None,
trust_negative_responses,