Fixes caching bug when CNAME leads to negative response

2023-09-28 15:22:29 -05:00 · 2023-09-28 15:22:29 -05:00 · 45bd92f4ac
commit 45bd92f4ac
parent c9a2ce42cb
1 changed files with 4 additions and 1 deletions
--- a/crates/resolver/src/caching_client.rs
+++ b/crates/resolver/src/caching_client.rs
@ -245,7 +245,10 @@ where
            Ok(Records::CnameChain {
                next: future,
                min_ttl: ttl,
-            }) => client.cname(future.await?, query, ttl),
+            }) => match future.await {
+                Ok(lookup) => client.cname(lookup, query, ttl),
+                Err(e) => client.cache(query, Err(e)),
+            },
            Ok(Records::Exists(rdata)) => client.cache(query, Ok(rdata)),
            Err(e) => client.cache(query, Err(e)),
        }