clean up new clippy warnings

crates/client/src/lib.rs

@@ -255,7 +255,6 @@ extern crate chrono;
 extern crate data_encoding;
 #[macro_use]
 extern crate data_encoding_macro;
-#[macro_use]
 extern crate failure;
 #[macro_use]
 extern crate futures;

crates/https/src/lib.rs

@@ -16,7 +16,6 @@ extern crate h2;
 extern crate http;
 #[macro_use]
 extern crate log;
-#[macro_use]
 extern crate failure;
 extern crate rustls;
 extern crate tokio_executor;

crates/proto/src/lib.rs

@@ -16,7 +16,6 @@ extern crate byteorder;
 extern crate data_encoding;
 #[cfg(test)]
 extern crate env_logger;
-#[macro_use]
 extern crate failure;
 #[macro_use]
 extern crate futures;

crates/proto/src/serialize/binary/encoder.rs

@@ -282,7 +282,8 @@ impl<'a> BinEncoder<'a> {
             return Err(ProtoErrorKind::CharacterDataTooLong {
                 max: 255,
                 len: char_bytes.len(),
-            }.into());
+            }
+            .into());
         }
 
         // first the length is written
@@ -368,7 +369,7 @@ impl<'a> BinEncoder<'a> {
         I: Iterator<Item = &'r &'e E>,
         E: 'r + 'e + BinEncodable,
     {
-        let mut iter = iter.map(|i| *i);
+        let mut iter = iter.cloned();
         self.emit_iter(&mut iter)
     }
 

crates/resolver/src/lib.rs

@@ -169,7 +169,6 @@
 #[cfg(feature = "dns-over-tls")]
 #[macro_use]
 extern crate cfg_if;
-#[macro_use]
 extern crate failure;
 #[macro_use]
 extern crate futures;

crates/resolver/src/name_server_pool.rs

@@ -907,7 +907,6 @@ where
 
     fn poll(&mut self) -> Poll<Self::Item, Self::Error> {
         // TODO: this resolves an odd unsized issue with the loop_fn future
-        use std::mem;
         let future;
 
         match *self {
@@ -940,7 +939,7 @@ where
                         // get a stable view for trying all connections
                         //   we split into chunks of the numeber of parallel requests to issue
                         let mut conns: Vec<NameServer<C, P>> = conns.clone();
-                        let request = mem::replace(request, None);
+                        let request = request.take();
                         let request = request.expect("bad state, mesage should never be None");
                         let request_loop = request.clone();
 

crates/server/src/authority/message_response.rs

@@ -81,7 +81,7 @@ where
             &mut EmptyOrQueries::from(self.queries),
             &mut self.answers,
             &mut self.name_servers,
-            &mut self.additionals.iter().map(|r| *r),
+            &mut self.additionals.iter().cloned(),
             self.edns.as_ref(),
             &self.sig0,
             encoder,

crates/server/src/lib.rs

@@ -30,7 +30,6 @@
 extern crate bytes;
 extern crate chrono;
 extern crate env_logger;
-#[macro_use]
 extern crate failure;
 extern crate futures;
 #[macro_use]

scripts/run_clippy.sh

@@ -28,6 +28,7 @@ CLIPPY_OPTS="-D warnings\
     -A clippy::type_complexity\
     -A clippy::unreadable_literal\
     -A clippy::useless_attribute\
+    -A clippy::unused_unit\
 "
 
 cargo clippy ${TARGETS_OPTS:?} -- ${CLIPPY_OPTS:?}