From d79581bdcc01b458cf24d846cb56275f1b55f8db Mon Sep 17 00:00:00 2001
From: Jorge Aparicio <jorge.aparicio@ferrous-systems.com>
Date: Mon, 5 Feb 2024 14:27:10 +0100
Subject: [PATCH] fix warnings

---
 src/authoritative_name_server.rs |  6 +++---
 src/container.rs                 | 14 +++++++-------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/authoritative_name_server.rs b/src/authoritative_name_server.rs
index edbb4b57..6b6209d6 100644
--- a/src/authoritative_name_server.rs
+++ b/src/authoritative_name_server.rs
@@ -46,8 +46,8 @@ impl Drop for AuthoritativeNameServer {
 }
 
 fn tld_zone(domain: &str) -> String {
-    assert!(domain.ends_with("."));
-    assert!(!domain.starts_with("."));
+    assert!(domain.ends_with('.'));
+    assert!(!domain.starts_with('.'));
 
     let mut env = Environment::new();
     let name = "main.zone";
@@ -67,7 +67,7 @@ fn root_zone() -> String {
 }
 
 fn nsd_conf(domain: &str) -> String {
-    assert!(domain.ends_with("."));
+    assert!(domain.ends_with('.'));
 
     let mut env = Environment::new();
     let name = "nsd.conf";
diff --git a/src/container.rs b/src/container.rs
index 9753106f..e52ca0ef 100644
--- a/src/container.rs
+++ b/src/container.rs
@@ -11,7 +11,7 @@ use crate::Result;
 
 pub struct Container {
     id: String,
-    name: String,
+    _name: String,
 }
 
 impl Container {
@@ -33,7 +33,7 @@ impl Container {
 
         let mut command = Command::new("docker");
         command
-            .args(&["build", "-t"])
+            .args(["build", "-t"])
             .arg(&image_tag)
             .arg("-f")
             .arg(dockerfile_path)
@@ -50,7 +50,7 @@ impl Container {
             "{binary}-{pid}-{}",
             COUNT.fetch_add(1, atomic::Ordering::Relaxed)
         );
-        command.args(&["run", "--rm", "--detach", "--name", &container_name]);
+        command.args(["run", "--rm", "--detach", "--name", &container_name]);
         let output = command
             .arg("-it")
             .arg(image_tag)
@@ -65,7 +65,7 @@ impl Container {
         dbg!(&id);
         let container = Self {
             id,
-            name: container_name,
+            _name: container_name,
         };
         dbg!(container.ip_addr()?);
 
@@ -98,7 +98,7 @@ impl Container {
 
     pub fn exec(&self, cmd: &[&str]) -> Result<Output> {
         let mut command = Command::new("docker");
-        command.args(&["exec", "-t", &self.id]).args(cmd);
+        command.args(["exec", "-t", &self.id]).args(cmd);
 
         let output = command.output()?;
 
@@ -107,7 +107,7 @@ impl Container {
 
     pub fn spawn(&self, cmd: &[&str]) -> Result<Child> {
         let mut command = Command::new("docker");
-        command.args(&["exec", "-t", &self.id]).args(cmd);
+        command.args(["exec", "-t", &self.id]).args(cmd);
 
         let child = command.spawn()?;
 
@@ -118,7 +118,7 @@ impl Container {
     pub fn ip_addr(&self) -> Result<String> {
         let mut command = Command::new("docker");
         command
-            .args(&[
+            .args([
                 "inspect",
                 "-f",
                 "{{range.NetworkSettings.Networks}}{{.IPAddress}}{{end}}",