colin/hickory-dns
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

change results of validation to always return records

Browse Source
This commit is contained in:
Benjamin Fry
2023-11-25 22:11:18 -08:00
parent 1d2a1df0ee
commit ec806ae445
3 changed files with 40 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
crates/resolver/src/async_resolver.rs
View File

@@ -612,6 +612,10 @@ pub mod testing {
);
}
}
for record in response.as_lookup().record_iter() {
assert!(record.proof().is_secure())
}
}
/// Test IP lookup from domains that exist but unsigned with DNSSEC validation.
@@ -622,7 +626,7 @@ pub mod testing {
mut exec: E,
handle: R,
) {
use crate::error::*;
use crate::{error::*, lookup};
use proto::rr::RecordType;
let resolver = AsyncResolver::new(
ResolverConfig::default(),
@@ -637,18 +641,9 @@ pub mod testing {
// needs to be a domain that exists, but is not signed (eventually this will be)
let response = exec.block_on(resolver.lookup_ip("hickory-dns.org."));
assert!(response.is_err());
let error = response.unwrap_err();
let error_str = format!("{error}");
let name = Name::from_str("hickory-dns.org.").unwrap();
let expected_str = format!(
"proto error: failed to validate RRSIGs: Bogus: ds record should exist: {name}"
);
assert_eq!(error_str, expected_str);
if let ResolveErrorKind::Proto(_) = *error.kind() {
} else {
panic!("wrong error")
let lookup_ip = response.unwrap();
for record in lookup_ip.as_lookup().record_iter() {
assert!(record.proof().is_bogus())
}
}