colin/iio-sensor-proxy
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

iio: Remove fscanf usage in _write_sysfs_string()

Browse Source 
From Coverity:
iio-sensor-proxy-3.3/src/iio-buffer-utils.c:435: dont_call: "fscanf" assumes an arbitrarily long string, so callers must use correct precision specifiers or never use "fscanf".

This also fixes the temp variable being reused to parse the contents of
the sysfs file before being freed. How this behaves depends on the
length of the sysfs file path and the length of the string inside the
file.
This commit is contained in:
Bastien Nocera
2022-03-25 16:39:12 +01:00
parent 7ba893a6c9
commit ac053f8a12
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/iio-buffer-utils.c
View File

@@ -402,6 +402,7 @@ _write_sysfs_string (const char *filename,
{ {
g_autoptr(FILE) sysfsfp = NULL; g_autoptr(FILE) sysfsfp = NULL;
g_autofree char *temp = NULL; g_autofree char *temp = NULL;
g_autofree char *contents = NULL;
temp = g_build_filename (basedir, filename, NULL); temp = g_build_filename (basedir, filename, NULL);
sysfsfp = fopen (temp, "w"); sysfsfp = fopen (temp, "w");
@@ -409,19 +410,16 @@ _write_sysfs_string (const char *filename,
return -errno; return -errno;
} }
fprintf(sysfsfp, "%s", val); fprintf(sysfsfp, "%s", val);
g_clear_pointer (&sysfsfp, fclose);
/* Verify? */ /* Verify? */
if (!verify) if (!verify)
return 0; return 0;
sysfsfp = fopen(temp, "r"); g_clear_pointer (&sysfsfp, fclose);
if (sysfsfp == NULL) { if (!g_file_get_contents (temp, &contents, NULL, NULL) ||
return -errno; g_strcmp0 (contents, val) != 0) {
} g_message ("WTA");
if (fscanf(sysfsfp, "%s", temp) != 1 || g_warning ("Possible failure in string write of '%s' Should be '%s' written to %s\n",
strcmp(temp, val) != 0) { contents ?: "(null)", val, temp);
g_warning ("Possible failure in string write of %s Should be %s written to %s\\%s\n",
temp, val, basedir, filename);
return -1; return -1;
} }