From 4da88c662bea868574f9ee670231288cc94d9a36 Mon Sep 17 00:00:00 2001
From: Kristian Vos <k.vos@kvos.dev>
Date: Sat, 11 May 2024 19:22:29 +0200
Subject: [PATCH] Improve PPP config, notably the preview mode for front camera

---
 config/pine64,pinephone-pro.conf | 61 ++++++++++++++++----------------
 1 file changed, 31 insertions(+), 30 deletions(-)

diff --git a/config/pine64,pinephone-pro.conf b/config/pine64,pinephone-pro.conf
index 6a6a1ce..01de0e2 100644
--- a/config/pine64,pinephone-pro.conf
+++ b/config/pine64,pinephone-pro.conf
@@ -5,6 +5,7 @@ Model: "PinePhone Pro";
 Rear: {
     SensorDriver: "imx258";
     BridgeDriver: "rkisp1";
+    FlashPath: "/sys/class/leds/white:flash";
 
     Modes: (
         {
@@ -30,7 +31,7 @@ Rear: {
                 {Type: "Mode", Entity: "rkisp1_resizer_mainpath", Pad: 1}
             );
         },
-        # { # Doesn't work in megapixels yet
+        # { # Doesn't work well in Megapixels yet
         #     Width: 4208;
         #     Height: 3120;
         #     Rate: 30;
@@ -67,14 +68,14 @@ Rear: {
                 {Type: "Link", From: "rkisp1_csi", FromPad: 1, To: "rkisp1_isp", ToPad: 0},
                 {Type: "Link", From: "rkisp1_isp", FromPad: 2, To: "rkisp1_resizer_mainpath", ToPad: 0},
                 {Type: "Mode", Entity: "imx258", Format: "RGGB10P"},
-                {Type: "Mode", Entity: "rkisp1_csi", Pad: 0},
-                {Type: "Mode", Entity: "rkisp1_isp", Pad: 0},
+                {Type: "Mode", Entity: "rkisp1_csi"},
+                {Type: "Mode", Entity: "rkisp1_isp"},
                 {Type: "Mode", Entity: "rkisp1_isp", Pad: 2, Format: "RGGB8"},
-                {Type: "Mode", Entity: "rkisp1_resizer_mainpath", Pad: 0},
+                {Type: "Mode", Entity: "rkisp1_resizer_mainpath"},
                 {Type: "Mode", Entity: "rkisp1_resizer_mainpath", Pad: 1},
-                {Type: "Crop", Entity: "rkisp1_isp", Pad: 0},
+                {Type: "Crop", Entity: "rkisp1_isp"},
                 {Type: "Crop", Entity: "rkisp1_isp", Pad: 2},
-                {Type: "Crop", Entity: "rkisp1_resizer_mainpath", Pad: 0},
+                {Type: "Crop", Entity: "rkisp1_resizer_mainpath"}
             );
         },
     );
@@ -108,12 +109,12 @@ Front: {
                 {Type: "Mode", Entity: "rkisp1_resizer_mainpath", Pad: 1}
             );
         },
-        # { # Doesn't work in megapixels yet
+        # { # Doesn't work well in Megapixels yet
         #     Width: 3264;
         #     Height: 2448;
         #     Rate: 30;
         #     Format: "BGGR10";
-        #     Rotate: 270;
+        #     Rotate: 90;
         #     FocalLength: 3.33;
         #     FNumber: 3.0;
 
@@ -131,28 +132,28 @@ Front: {
         #         {Type: "Mode", Entity: "rkisp1_resizer_mainpath", Pad: 1}
         #     );
         # },
-        # { # Doesn't work in megapixels yet
-        #     Width: 1632;
-        #     Height: 1224;
-        #     Rate: 30;
-        #     Format: "YUYV";
-        #     Rotate: 270;
-        #     FocalLength: 3.33;
-        #     FNumber: 3.0;
+        {
+            Width: 1048;
+            Height: 780;
+            Rate: 30;
+            Format: "BGGR8";
+            Rotate: 90;
+            FocalLength: 3.33;
+            FNumber: 3.0;
 
-        #     Pipeline: (
-        #         {Type: "Link", From: "ov8858", FromPad: 0, To: "rkisp1_csi", ToPad: 0},
-        #         {Type: "Link", From: "rkisp1_csi", FromPad: 1, To: "rkisp1_isp", ToPad: 0},
-        #         {Type: "Link", From: "rkisp1_isp", FromPad: 2, To: "rkisp1_resizer_selfpath", ToPad: 0},
-        #         {Type: "Mode", Entity: "ov8858", Format: "BGGR10"},
-        #         {Type: "Mode", Entity: "rkisp1_csi"},
-        #         {Type: "Mode", Entity: "rkisp1_isp"},
-        #         {Type: "Mode", Entity: "rkisp1_isp", Pad: 2, Format: "YUYV"},
-        #         {Type: "Crop", Entity: "rkisp1_isp"}, # Cropped by default
-        #         {Type: "Crop", Entity: "rkisp1_isp", Pad: 2}, # Cropped by default
-        #         {Type: "Mode", Entity: "rkisp1_resizer_selfpath"},
-        #         {Type: "Mode", Entity: "rkisp1_resizer_selfpath", Pad: 1}
-        #     );
-        # }
+            Pipeline: (
+                {Type: "Link", From: "ov8858", FromPad: 0, To: "rkisp1_csi", ToPad: 0},
+                {Type: "Link", From: "rkisp1_csi", FromPad: 1, To: "rkisp1_isp", ToPad: 0},
+                {Type: "Link", From: "rkisp1_isp", FromPad: 2, To: "rkisp1_resizer_mainpath", ToPad: 0},
+                {Type: "Mode", Entity: "ov8858", Format: "BGGR10", Width: 1632, Height: 1224},
+                {Type: "Mode", Entity: "rkisp1_csi"},
+                {Type: "Mode", Entity: "rkisp1_isp"},
+                {Type: "Mode", Entity: "rkisp1_isp", Pad: 2, Format: "BGGR8", Width: 1048, Height: 780},
+                {Type: "Crop", Entity: "rkisp1_isp"}, # Cropped by default
+                {Type: "Crop", Entity: "rkisp1_isp", Pad: 2}, # Cropped by default
+                {Type: "Mode", Entity: "rkisp1_resizer_mainpath"},
+                {Type: "Mode", Entity: "rkisp1_resizer_mainpath", Pad: 1}
+            );
+        }
     );
 };
\ No newline at end of file