colin/libmegapixels
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

load_camera: initialize with calloc to avoid uninitialized reads

Browse Source 
in particular: if a sensor can't be found, then camera->sensor_path is
unassigned. this would cause a segfault later, in libmegapixels_open.
This commit is contained in:
Colin
2024-05-19 02:41:30 +00:00
parent db064d4eee
commit dec641dc51
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/parse.c
View File

@@ -191,10 +191,7 @@ load_camera(libmegapixels_devconfig *config, config_t *cfg, const char *name)
return -1; return -1;
} }
libmegapixels_camera *camera; libmegapixels_camera *camera;
camera = malloc(sizeof(libmegapixels_camera)); camera = calloc(1, sizeof(libmegapixels_camera));
camera->sensor_fd = 0;
camera->media_fd = 0;
camera->video_fd = 0;
int res = find_media_node(camera, bridge_driver, sensor_driver); int res = find_media_node(camera, bridge_driver, sensor_driver);
if (res < 0) { if (res < 0) {