colin/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

uio: pruss: fix missing iounmap() in pruss_probe()

Browse Source 
platform_get_irq() is called after ioremap(), if it fails,
iounmap() needs be called in error the path.

Fixes: 2fd84b9b83 ("uio: pruss: fix to check return value of platform_get_irq() in pruss_probe()")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20230808123827.560603-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Yang Yingliang 2023-08-08 20:38:27 +08:00 committed by Greg Kroah-Hartman
parent e75850b457
commit 979ca1ca1f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/uio/uio_pruss.c
View File

@ -177,7 +177,7 @@ static int pruss_probe(struct platform_device *pdev)
ret = platform_get_irq(pdev, 0);
if (ret < 0)
goto err_free_ddr_vaddr;
goto err_unmap;
gdev->hostirq_start = ret;
gdev->pintc_base = pdata->pintc_base;
@ -215,6 +215,7 @@ static int pruss_probe(struct platform_device *pdev)
for (i = 0, p = gdev->info; i < cnt; i++, p++) {
uio_unregister_device(p);
}
err_unmap:
iounmap(gdev->prussio_vaddr);
err_free_ddr_vaddr:
dma_free_coherent(dev, extram_pool_sz, gdev->ddr_vaddr,