From 0a2945e9a91f169c17fa34cad39a22db2c31aa3c Mon Sep 17 00:00:00 2001 From: Colin Date: Tue, 15 Oct 2024 02:15:06 +0000 Subject: [PATCH] eg25-control: document better the modem GPIO lines --- pkgs/by-name/eg25-control/eg25-control | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/eg25-control/eg25-control b/pkgs/by-name/eg25-control/eg25-control index 844a318b2..7820e2bef 100755 --- a/pkgs/by-name/eg25-control/eg25-control +++ b/pkgs/by-name/eg25-control/eg25-control @@ -448,12 +448,12 @@ class PinePhoneGpioPhy(GpioPhy): STATUS = 1, 233 # PH9 class PinePhoneProGpioPhy(GpioPhy): - DTR = 0, 3 # gpio0, RK_PA3 - PWRKEY = 0, 13 # gpio0, RK_PB5 - RESET = 3, 8 # gpio3, RK_PB0 - APREADY = 0, 12 # gio0, RK_RB4 ('host-ready-gpios') + DTR = 0, 3 # gpio0, RK_PA3 (AKA "4G_DTR"; RK3399 -> EG25) + PWRKEY = 0, 13 # gpio0, RK_PB5 (more accurately, this is "4G_REG_ON", which pulls PWRKEY *low* when driven *high*) + RESET = 3, 8 # gpio3, RK_PB0 (more accurately, this is "4G_RST", which pulls RESET_N *low* when driven *high*) + APREADY = 0, 12 # gio0, RK_RB4 ('host-ready-gpios'. AKA "AP_READY") DISABLE = 0, 8 # gpio0, RK_PB0 (TODO: megi has this marked active HIGH, not LOW) - STATUS = 3, 6 # gpio3, RK_PA6 + STATUS = 3, 6 # gpio3, RK_PA6 (AKA "4G_Status"; EG25 -> RK3399) class Sequencer: def __init__(self, executor: Executor, modem: str, modem_phy: Phy, state_fs: Filesystem):