From 1483dac9418e4c7a6b75c0d25eb3f6e9a0f46ae8 Mon Sep 17 00:00:00 2001
From: Colin <colin@uninsane.org>
Date: Wed, 8 Nov 2023 10:54:48 +0000
Subject: [PATCH] cross: explain the webkitgtk situation better

---
 overlays/cross.nix | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/overlays/cross.nix b/overlays/cross.nix
index 7ef86955..9022b1e8 100644
--- a/overlays/cross.nix
+++ b/overlays/cross.nix
@@ -2097,7 +2097,11 @@ in {
 
   webkitgtk = prev.webkitgtk.overrideAttrs (upstream: {
     # fixes "wayland-scanner: line 5: syntax error: unterminated quoted string"
-    # if this works i can maybe remove `wayland` from nativeBuildInputs altogether?
+    # also: `/nix/store/nnnn-wayland-aarch64-unknown-linux-gnu-1.22.0-bin/bin/wayland-scanner: line 0: syntax error: unexpected word (expecting ")")`
+    # with this i can maybe remove `wayland` from nativeBuildInputs, too?
+    # note that `webkitgtk` != `webkitgtk_6_0`, so this patch here might be totally unnecessary.
+    # 2023/11/06: hostPkgs.moby.webkitgtk_6_0 builds fine on servo; stock pkgsCross.aarch64-multiplatform.webkitgtk_6_0 does not.
+    # 2023/11/06: out for PR: <https://github.com/NixOS/nixpkgs/pull/265968>
     cmakeFlags = upstream.cmakeFlags ++ [
       "-DWAYLAND_SCANNER=${final.buildPackages.wayland-scanner}/bin/wayland-scanner"
     ];