From 9caa2a0a170a8e3f89c93eed6cfdd890cffb4d48 Mon Sep 17 00:00:00 2001
From: Colin <colin@uninsane.org>
Date: Mon, 19 Jun 2023 09:48:57 +0000
Subject: [PATCH] koreader: note to self that the os.execute bug may affect
 other features

---
 .../programs/koreader/2-colin-NetworkManager-isConnected.lua   | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/hosts/common/programs/koreader/2-colin-NetworkManager-isConnected.lua b/hosts/common/programs/koreader/2-colin-NetworkManager-isConnected.lua
index 6130b6d9..b7c813d6 100644
--- a/hosts/common/programs/koreader/2-colin-NetworkManager-isConnected.lua
+++ b/hosts/common/programs/koreader/2-colin-NetworkManager-isConnected.lua
@@ -17,6 +17,9 @@
 -- specifically, `os.execute` is not *expected* to return 0. it returns `true` on success:
 -- <https://www.lua.org/manual/5.3/manual.html#pdf-os.execute>
 -- this apparently changed from 5.1 -> 5.2
+--
+-- XXX: this same bug likely applies to `isCommand` and `runCommand` in <frontend/device/sdl/device.lua>
+-- - that would manifest as wikipedia links failing to open in external application (xdg-open)
 
 local logger = require("logger")
 logger.info("applying colin patch")