From c617d4d0cde1b2ac78418b1907eda3f97704efbb Mon Sep 17 00:00:00 2001 From: Colin Date: Tue, 15 Oct 2024 17:53:37 +0000 Subject: [PATCH] eg25-control: remove old TODOs --- pkgs/by-name/eg25-control/eg25-control | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/pkgs/by-name/eg25-control/eg25-control b/pkgs/by-name/eg25-control/eg25-control index 7820e2bef..fd1bf7c9d 100755 --- a/pkgs/by-name/eg25-control/eg25-control +++ b/pkgs/by-name/eg25-control/eg25-control @@ -396,7 +396,6 @@ class GpioPhy: time.sleep(1.0) self.set_gpio(self.PWRKEY, gpiod.line.Value.INACTIVE) - # TODO: switch 'status' key to input (megi's modem-power claims it can be multiplexed with other stuff, so shouldn't be actively driven when possible) # power-up takes 3-5s; power-down takes 12-15s for i in range(20): self.dump_debug_info() @@ -452,7 +451,7 @@ class PinePhoneProGpioPhy(GpioPhy): PWRKEY = 0, 13 # gpio0, RK_PB5 (more accurately, this is "4G_REG_ON", which pulls PWRKEY *low* when driven *high*) RESET = 3, 8 # gpio3, RK_PB0 (more accurately, this is "4G_RST", which pulls RESET_N *low* when driven *high*) APREADY = 0, 12 # gio0, RK_RB4 ('host-ready-gpios'. AKA "AP_READY") - DISABLE = 0, 8 # gpio0, RK_PB0 (TODO: megi has this marked active HIGH, not LOW) + DISABLE = 0, 8 # gpio0, RK_PB0 (NB: megi has this (incorrectly) marked active HIGH, not LOW) STATUS = 3, 6 # gpio3, RK_PA6 (AKA "4G_Status"; EG25 -> RK3399) class Sequencer: