megapixels: fix folder icon to actually open ~/Pictures/Photos

TODO.md

@@ -1,5 +1,6 @@
 ## BUGS
 - moby: mpv uosc always starts at 40% volume
+- moby: rofi crashes sporadically
 - mpv: no way to exit fullscreen video on moby
   - uosc hides controls on FS, and touch doesn't support unhiding
 - i accidentally create sub-splits in sway all the time

hosts/common/home/xdg-dirs.nix

@@ -3,11 +3,15 @@
 {
   # XDG defines things like ~/Desktop, ~/Downloads, etc.
   # these clutter the home, so i mostly don't use them.
+  # note that several of these are not actually standardized anywhere.
+  # some are even non-conventional, like:
+  # - XDG_PHOTOS_DIR: only works because i patch e.g. megapixels
   sane.user.fs.".config/user-dirs.dirs".symlink.text = ''
     XDG_DESKTOP_DIR="$HOME/.xdg/Desktop"
     XDG_DOCUMENTS_DIR="$HOME/dev"
     XDG_DOWNLOAD_DIR="$HOME/tmp"
     XDG_MUSIC_DIR="$HOME/Music"
+    XDG_PHOTOS_DIR="$HOME/Pictures/Photos"
     XDG_PICTURES_DIR="$HOME/Pictures"
     XDG_PUBLICSHARE_DIR="$HOME/.xdg/Public"
     XDG_SCREENSHOTS_DIR="$HOME/Pictures/Screenshots"

hosts/common/programs/megapixels.nix

@@ -1,6 +1,16 @@
-{ ... }:
+{ pkgs, ... }:
 {
   sane.programs.megapixels = {
+    packageUnwrapped = pkgs.megapixels.overrideAttrs (upstream: {
+      postPatch = (upstream.postPatch or "") + ''
+        # 2024/04/21: patch it to save photos in a more specific directory
+        substituteInPlace src/process_pipeline.c \
+          --replace-fail 'XDG_PICTURES_DIR' 'XDG_PHOTOS_DIR'
+        # 2024/04/21: patch it so the folder button works
+        substituteInPlace src/main.c \
+          --replace-fail 'g_get_user_special_dir(G_USER_DIRECTORY_PICTURES)' 'getenv("XDG_PHOTOS_DIR")'
+      '';
+    });
     # megapixels sandboxing is tough:
     # if misconfigured, preview will alternately be OK, black, or only 1/4 of it will be rendered -- with no obvious pattern.
     # adding all of ~ to the sandbox will sometimes (?) fix the flakiness, even when `strace` doesn't show it accessing any files...
@@ -16,10 +26,8 @@
     sandbox.extraHomePaths = [
       ".config/dconf"  #< else it segfaults during post-process
       # ".config/megapixels"
-      ".local/share/applications"  #< needed for viewing photos, until i can sort out the portal stuff
       ".cache/mesa_shader_cache"  # loads way faster
-      "tmp"
-      "Pictures"  #< TODO: make this Pictures/Photos and save photos there
+      "Pictures/Photos"
       # also it addresses a lot via relative path.
     ];
     sandbox.extraPaths = [
@@ -37,6 +45,12 @@
     sandbox.extraRuntimePaths = [
       "dconf"  #< else it's very spammy, and slow
     ];
+    sandbox.extraConfig = [
+      # XXX(2024/04/21): without this it fails to convert .dng -> .jpg.
+      #   "bwrap: open /proc/34/ns/ns failed: No such file or directory"
+      "--sane-sandbox-keep-namespace" "pid"
+    ];
+
     suggestedPrograms = [ "dconf" ];  #< not sure if necessary
   };
 }