From 0825957f5441f5892a123998730af53fa2056f00 Mon Sep 17 00:00:00 2001 From: Silvan Mosberger Date: Sun, 21 Jan 2024 22:47:10 +0100 Subject: [PATCH] workflows/check-by-name: Trigger on base branch changes Not doing this can cause CI to report a misleading result when it wasn't retriggered after a base branch change. --- .github/workflows/check-by-name.yml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check-by-name.yml b/.github/workflows/check-by-name.yml index 4295c6475848..94875e67b649 100644 --- a/.github/workflows/check-by-name.yml +++ b/.github/workflows/check-by-name.yml @@ -8,7 +8,15 @@ name: Check pkgs/by-name # see pkgs/test/nixpkgs-check-by-name/scripts/README.md on: # Using pull_request_target instead of pull_request avoids having to approve first time contributors - pull_request_target + pull_request_target: + # This workflow depends on the base branch of the PR, + # but changing the base branch is not included in the default trigger events, + # which would be `opened`, `synchronize` or `reopened`. + # Instead it causes an `edited` event, so we need to add it explicitly here + # While `edited` is also triggered when the PR title/body is changed, + # this PR action is fairly quick, and PR's don't get edited that often, + # so it shouldn't be a problem + types: [opened, synchronize, reopened, edited] permissions: # We need this permission to cancel the workflow run if there's a merge conflict