colin/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

p4v: wrap derivation to avoid polluting PATH

Browse Source 
P4V includes a bunch of extra binaries in its bin directory that are
only useful as part of their wrapper scripts. They really belong in a
libexec-style directory, but their wrappers hardcode bin, so we take the
easier approach of wrapping their wrappers.
This commit is contained in:
Noah Fontes 2022-09-06 15:53:30 -07:00
parent 98d026a144
commit 0defcde4c0
No known key found for this signature in database
GPG Key ID: 85B8C0A0B15FF53F
1 changed files with 70 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
pkgs/applications/version-management/p4v/default.nix
View File

@ -27,10 +27,14 @@
, xcbutilwm
}:
stdenv.mkDerivation {
let
pname = "p4v";
version = "2022.2.2336701";
unwrapped = stdenv.mkDerivation {
pname = "${pname}-unwrapped";
inherit version;
src = fetchurl {
url = "https://web.archive.org/web/20220902181457/https://ftp.perforce.com/perforce/r22.2/bin.linux26x86_64/p4v.tgz";
sha256 = "8fdade4aafe25f568a61cfd80823aa90599c2a404b7c6b4a0862c84b07a9f8d2";
@ -82,4 +86,22 @@ stdenv.mkDerivation {
platforms = [ "x86_64-linux" ];
maintainers = with lib.maintainers; [ impl nathyong nioncode ];
};
};
in
stdenv.mkDerivation {
inherit pname version;
# Build a "clean" version of the package so that we don't add extra ".bin" or
# configuration files to users' PATHs. We can't easily put the unwrapped
# package files in libexec (where they belong, probably) because the upstream
# wrapper scripts have the bin directory hardcoded.
buildCommand = ''
mkdir -p $out/bin
for f in p4admin p4merge p4v p4vc; do
ln -s ${unwrapped}/bin/$f $out/bin
done
'';
preferLocalBuild = true;
inherit (unwrapped) meta passthru;
}