From 9333e47b28d9da0d20479b7722ee4de195848bed Mon Sep 17 00:00:00 2001 From: Chuck Date: Wed, 5 Feb 2020 10:21:35 -0800 Subject: [PATCH 1/3] nodejs: isArm -> isAarch32 This is the last package reference to isArm. isArm is deprecated after 18.03. This substitution was performed tree-wide in #37401. --- pkgs/development/web/nodejs/nodejs.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/development/web/nodejs/nodejs.nix b/pkgs/development/web/nodejs/nodejs.nix index ea23ad06cd21..dce8479d219e 100644 --- a/pkgs/development/web/nodejs/nodejs.nix +++ b/pkgs/development/web/nodejs/nodejs.nix @@ -61,18 +61,18 @@ in configureFlags = let isCross = stdenv.hostPlatform != stdenv.buildPlatform; host = stdenv.hostPlatform.platform; - isArm = stdenv.hostPlatform.isArm; + isAarch32 = stdenv.hostPlatform.isAarch32; in sharedConfigureFlags ++ [ "--without-dtrace" ] ++ (optionals isCross [ "--cross-compiling" "--without-intl" "--without-snapshot" - ]) ++ (optionals (isCross && isArm && hasAttr "fpu" host.gcc) [ + ]) ++ (optionals (isCross && isAarch32 && hasAttr "fpu" host.gcc) [ "--with-arm-fpu=${host.gcc.fpu}" - ]) ++ (optionals (isCross && isArm && hasAttr "float-abi" host.gcc) [ + ]) ++ (optionals (isCross && isAarch32 && hasAttr "float-abi" host.gcc) [ "--with-arm-float-abi=${host.gcc.float-abi}" - ]) ++ (optionals (isCross && isArm) [ + ]) ++ (optionals (isCross && isAarch32) [ "--dest-cpu=arm" ]) ++ extraConfigFlags; From a7835b936ed8836475ca1aab01e921c3b256776d Mon Sep 17 00:00:00 2001 From: Chuck Date: Wed, 5 Feb 2020 10:54:54 -0800 Subject: [PATCH 2/3] lib.systems.elaborate: isArm -> isAarch32 This is the last reference to isArm. isArm is deprecated after 18.03. This substitution was performed tree-wide in #37401. --- lib/systems/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/systems/default.nix b/lib/systems/default.nix index 026117cc34fd..36afdae38668 100644 --- a/lib/systems/default.nix +++ b/lib/systems/default.nix @@ -84,7 +84,7 @@ rec { else final.parsed.cpu.name; qemuArch = - if final.isArm then "arm" + if final.isAarch32 then "arm" else if final.isx86_64 then "x86_64" else if final.isx86 then "i386" else { From 5d4821141bde599d6e40c14049b0d23bfc367b57 Mon Sep 17 00:00:00 2001 From: Chuck Date: Wed, 5 Feb 2020 10:26:21 -0800 Subject: [PATCH 3/3] stdenv: Remove isArm (use isAarch32 instead) isArm has been deprecated for three releases. All references have been removed. Tree-wide substitution was performed in #37401 21 months ago. --- lib/systems/inspect.nix | 3 --- pkgs/stdenv/generic/default.nix | 3 --- 2 files changed, 6 deletions(-) diff --git a/lib/systems/inspect.nix b/lib/systems/inspect.nix index d1980c6dff81..01dcf0787dfa 100644 --- a/lib/systems/inspect.nix +++ b/lib/systems/inspect.nix @@ -55,9 +55,6 @@ rec { isEfi = map (family: { cpu.family = family; }) [ "x86" "arm" "aarch64" ]; - - # Deprecated after 18.03 - isArm = isAarch32; }; matchAnyAttrs = patterns: diff --git a/pkgs/stdenv/generic/default.nix b/pkgs/stdenv/generic/default.nix index df2d35d541b8..77d70e84258d 100644 --- a/pkgs/stdenv/generic/default.nix +++ b/pkgs/stdenv/generic/default.nix @@ -137,9 +137,6 @@ let isi686 isx86_32 isx86_64 is32bit is64bit isAarch32 isAarch64 isMips isBigEndian; - isArm = lib.warn - "`stdenv.isArm` is deprecated after 18.03. Please use `stdenv.isAarch32` instead" - hostPlatform.isAarch32; # The derivation's `system` is `buildPlatform.system`. inherit (buildPlatform) system;