From 168793f151a0f2827c4eedc8ded2e149ab0300e4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andr=C3=A9=20Schr=C3=B6der?= Date: Sun, 21 Apr 2024 11:36:17 +0200 Subject: [PATCH] digital-ocean: revert "make it easier to use disko" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts parts of commit d87c4e1a720f827996c282d0e194850a8903cebe from @Mic92 After switching from nixos-23.11 to nixos-unstable, I got the following error: ``` $ nixos-rebuild switch --flake nixos/#digitalocean ... error: Failed assertions: - You must set the option ‘boot.loader.grub.devices’ or 'boot.loader.grub.mirroredBoots' to make the system bootable. ``` In my nixos config I don't set boot.loader.grub.devices or boot.loader.grub.mirroredBoots explicitly. It seems like the values are not really defaulted via mkDefault? I am still relatively new to Nix, not sure how to fix this properly, so I am proposing to revert this change. --- nixos/modules/virtualisation/digital-ocean-config.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nixos/modules/virtualisation/digital-ocean-config.nix b/nixos/modules/virtualisation/digital-ocean-config.nix index 2d5bc0661d48..4ef2b85551c6 100644 --- a/nixos/modules/virtualisation/digital-ocean-config.nix +++ b/nixos/modules/virtualisation/digital-ocean-config.nix @@ -41,7 +41,7 @@ with lib; kernelParams = [ "console=ttyS0" "panic=1" "boot.panic_on_fail" ]; initrd.kernelModules = [ "virtio_scsi" ]; kernelModules = [ "virtio_pci" "virtio_net" ]; - loader.grub.devices = lib.mkDefault ["/dev/vda"]; + loader.grub.devices = ["/dev/vda"]; }; services.openssh = { enable = mkDefault true;