From dc70144603be8760def7358420a0ff3535b09add Mon Sep 17 00:00:00 2001 From: John Chadwick Date: Sat, 6 Apr 2024 22:52:24 -0400 Subject: [PATCH 1/2] _86Box: reformat according to RFC166 --- pkgs/applications/emulators/86box/default.nix | 82 +++++++++++-------- 1 file changed, 50 insertions(+), 32 deletions(-) diff --git a/pkgs/applications/emulators/86box/default.nix b/pkgs/applications/emulators/86box/default.nix index 4e2cb8541205..e509bd9bff9e 100644 --- a/pkgs/applications/emulators/86box/default.nix +++ b/pkgs/applications/emulators/86box/default.nix @@ -1,12 +1,30 @@ -{ stdenv, lib, fetchFromGitHub, cmake, pkg-config, makeWrapper, freetype, SDL2 -, glib, pcre2, openal, rtmidi, fluidsynth, jack2, alsa-lib, qt5, libvncserver -, discord-gamesdk, libpcap, libslirp +{ + stdenv, + lib, + fetchFromGitHub, + cmake, + pkg-config, + makeWrapper, + freetype, + SDL2, + glib, + pcre2, + openal, + rtmidi, + fluidsynth, + jack2, + alsa-lib, + qt5, + libvncserver, + discord-gamesdk, + libpcap, + libslirp, -, enableDynarec ? with stdenv.hostPlatform; isx86 || isAarch -, enableNewDynarec ? enableDynarec && stdenv.hostPlatform.isAarch -, enableVncRenderer ? false -, unfreeEnableDiscord ? false -, unfreeEnableRoms ? false + enableDynarec ? with stdenv.hostPlatform; isx86 || isAarch, + enableNewDynarec ? enableDynarec && stdenv.hostPlatform.isAarch, + enableVncRenderer ? false, + unfreeEnableDiscord ? false, + unfreeEnableRoms ? false, }: stdenv.mkDerivation (finalAttrs: { @@ -40,27 +58,28 @@ stdenv.mkDerivation (finalAttrs: { libslirp qt5.qtbase qt5.qttools - ] ++ lib.optional stdenv.isLinux alsa-lib - ++ lib.optional enableVncRenderer libvncserver; + ] ++ lib.optional stdenv.isLinux alsa-lib ++ lib.optional enableVncRenderer libvncserver; - cmakeFlags = lib.optional stdenv.isDarwin "-DCMAKE_MACOSX_BUNDLE=OFF" + cmakeFlags = + lib.optional stdenv.isDarwin "-DCMAKE_MACOSX_BUNDLE=OFF" ++ lib.optional enableNewDynarec "-DNEW_DYNAREC=ON" ++ lib.optional enableVncRenderer "-DVNC=ON" ++ lib.optional (!enableDynarec) "-DDYNAREC=OFF" ++ lib.optional (!unfreeEnableDiscord) "-DDISCORD=OFF"; - postInstall = lib.optionalString stdenv.isLinux '' - install -Dm644 -t $out/share/applications $src/src/unix/assets/net.86box.86Box.desktop + postInstall = + lib.optionalString stdenv.isLinux '' + install -Dm644 -t $out/share/applications $src/src/unix/assets/net.86box.86Box.desktop - for size in 48 64 72 96 128 192 256 512; do - install -Dm644 -t $out/share/icons/hicolor/"$size"x"$size"/apps \ - $src/src/unix/assets/"$size"x"$size"/net.86box.86Box.png - done; - '' - + lib.optionalString unfreeEnableRoms '' - mkdir -p $out/share/86Box - ln -s ${finalAttrs.passthru.roms} $out/share/86Box/roms - ''; + for size in 48 64 72 96 128 192 256 512; do + install -Dm644 -t $out/share/icons/hicolor/"$size"x"$size"/apps \ + $src/src/unix/assets/"$size"x"$size"/net.86box.86Box.png + done; + '' + + lib.optionalString unfreeEnableRoms '' + mkdir -p $out/share/86Box + ln -s ${finalAttrs.passthru.roms} $out/share/86Box/roms + ''; passthru = { roms = fetchFromGitHub { @@ -73,21 +92,20 @@ stdenv.mkDerivation (finalAttrs: { # Some libraries are loaded dynamically, but QLibrary doesn't seem to search # the runpath, so use a wrapper instead. - preFixup = let - libPath = lib.makeLibraryPath ([ - libpcap - ] ++ lib.optional unfreeEnableDiscord discord-gamesdk); - libPathVar = if stdenv.isDarwin then "DYLD_LIBRARY_PATH" else "LD_LIBRARY_PATH"; - in '' - makeWrapperArgs+=(--prefix ${libPathVar} : "${libPath}") - ''; + preFixup = + let + libPath = lib.makeLibraryPath ([ libpcap ] ++ lib.optional unfreeEnableDiscord discord-gamesdk); + libPathVar = if stdenv.isDarwin then "DYLD_LIBRARY_PATH" else "LD_LIBRARY_PATH"; + in + '' + makeWrapperArgs+=(--prefix ${libPathVar} : "${libPath}") + ''; meta = with lib; { description = "Emulator of x86-based machines based on PCem."; mainProgram = "86Box"; homepage = "https://86box.net/"; - license = with licenses; [ gpl2Only ] - ++ optional (unfreeEnableDiscord || unfreeEnableRoms) unfree; + license = with licenses; [ gpl2Only ] ++ optional (unfreeEnableDiscord || unfreeEnableRoms) unfree; maintainers = [ maintainers.jchw ]; platforms = platforms.linux; }; From b17d1291408e093831c7e47d85cf0118b445ff6c Mon Sep 17 00:00:00 2001 From: John Chadwick Date: Sat, 6 Apr 2024 22:53:44 -0400 Subject: [PATCH 2/2] _86Box: 4.1 -> 4.1.1 --- pkgs/applications/emulators/86box/default.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/emulators/86box/default.nix b/pkgs/applications/emulators/86box/default.nix index e509bd9bff9e..1e9b887d2d6a 100644 --- a/pkgs/applications/emulators/86box/default.nix +++ b/pkgs/applications/emulators/86box/default.nix @@ -29,13 +29,13 @@ stdenv.mkDerivation (finalAttrs: { pname = "86Box"; - version = "4.1"; + version = "4.1.1"; src = fetchFromGitHub { owner = "86Box"; repo = "86Box"; rev = "v${finalAttrs.version}"; - hash = "sha256-JYOJFXiUTLRs6AEMYNx88PwcVw13ChQzV1ZE5OtX6Ds="; + hash = "sha256-ioE0EVIXv/biXXvLqwhmtZ/RJM0nLqcE+i+CU+WXBY4="; }; nativeBuildInputs = [ @@ -86,7 +86,7 @@ stdenv.mkDerivation (finalAttrs: { owner = "86Box"; repo = "roms"; rev = "v${finalAttrs.version}"; - hash = "sha256-1HtoizO0QIGNjQTW0clzRp40h1ulw55+iTYz12UJSms="; + hash = "sha256-58nNTOLund/KeDlNwzwwihjFVigs/P0K8SN07zExE2c="; }; };