From 24b5eb61eb944036b5716788ead1b204fba08719 Mon Sep 17 00:00:00 2001 From: Charles Strahan Date: Sun, 25 Jan 2015 20:09:55 -0500 Subject: [PATCH] fetchzip: fix unpacking regression This resolves a regression introduced in fc0135370342, where providing a name without a proper extension breaks existing uses of fetchzip (they now fail to unpack). Of particular note, that commit broke all uses of fetchFromGitHub because it uses a name like so: "${repo}-${rev}-src" Fixes #5954 --- pkgs/build-support/fetchzip/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/build-support/fetchzip/default.nix b/pkgs/build-support/fetchzip/default.nix index ffdf45a18658..46e7d917160c 100644 --- a/pkgs/build-support/fetchzip/default.nix +++ b/pkgs/build-support/fetchzip/default.nix @@ -28,7 +28,7 @@ lib.overrideDerivation (fetchurl ({ mkdir "$unpackDir" cd "$unpackDir" - renamed="$TMPDIR/$name" + renamed="$TMPDIR/${baseNameOf url}" mv "$downloadedFile" "$renamed" unpackFile "$renamed"