rocm-related: remove ? null and related asserts

composable_kernel: remove ? null and related asserts

hipcub: remove ? null and related asserts

hipsparse: remove ? null and related asserts

miopen: remove ? null and related asserts

miopengemm: remove ? null and related asserts

rccl: remove ? null and related asserts

rocblas: remove ? null and related asserts

rocfft: remove ? null and related asserts

rocprim: remove ? null and related asserts

rocrand: remove ? null and related asserts

rocsparse: remove ? null and related asserts

rocthrust: remove ? null and related asserts

rocwmma: remove ? null and related asserts
This commit is contained in:
Madoura 2022-11-28 01:18:25 -06:00
parent 686606ead1
commit 2a44f631fa
No known key found for this signature in database
GPG Key ID: 3201136B3DB072F9
13 changed files with 42 additions and 97 deletions

View File

@ -5,14 +5,12 @@
, rocm-cmake
, hip
, openmp
, gtest ? null
, gtest
, buildTests ? false
, buildExamples ? false
, gpuTargets ? [ ] # gpuTargets = [ "gfx803" "gfx900" "gfx1030" ... ]
}:
assert buildTests -> gtest != null;
# Several tests seem to either not compile or have a race condition
# Undefined reference to symbol '_ZTIN7testing4TestE'
# Try removing this next update

View File

@ -9,15 +9,12 @@
, rocm-comgr
, rocprim
, hip
, gtest ? null
, gbenchmark ? null
, gtest
, gbenchmark
, buildTests ? false
, buildBenchmarks ? false
}:
assert buildTests -> gtest != null;
assert buildBenchmarks -> gbenchmark != null;
# CUB can also be used as a backend instead of rocPRIM.
stdenv.mkDerivation (finalAttrs: {
pname = "hipcub";

View File

@ -11,12 +11,10 @@
, hip
, gfortran
, git
, gtest ? null
, gtest
, buildTests ? false
}:
assert buildTests -> gtest != null;
# This can also use cuSPARSE as a backend instead of rocSPARSE
stdenv.mkDerivation (finalAttrs: {
pname = "hipsparse";

View File

@ -1,6 +1,7 @@
{ lib
, stdenv
, fetchFromGitHub
, fetchurl
, writeScript
, pkg-config
, cmake
@ -21,12 +22,11 @@
, boost
, sqlite
, bzip2
, texlive ? null
, doxygen ? null
, sphinx ? null
, python3Packages ? null
, zlib ? null
, fetchurl ? null
, texlive
, doxygen
, sphinx
, zlib
, python3Packages
, buildDocs ? true
, buildTests ? false
# LFS isn't working, so we will manually fetch these
@ -36,13 +36,6 @@
, useOpenCL ? false
}:
assert buildDocs -> texlive != null;
assert buildDocs -> doxygen != null;
assert buildDocs -> sphinx != null;
assert buildDocs -> python3Packages != null;
assert buildTests -> zlib != null;
assert fetchKDBs -> fetchurl != null;
let
latex = lib.optionalAttrs buildDocs texlive.combine {
inherit (texlive) scheme-small

View File

@ -6,22 +6,16 @@
, rocm-cmake
, rocm-opencl-runtime
, clang
, texlive ? null
, doxygen ? null
, sphinx ? null
, python3Packages ? null
, openblas ? null
, texlive
, doxygen
, sphinx
, openblas
, python3Packages
, buildDocs ? true
, buildTests ? false
, buildBenchmarks ? false
}:
assert buildDocs -> texlive != null;
assert buildDocs -> doxygen != null;
assert buildDocs -> sphinx != null;
assert buildDocs -> python3Packages != null;
assert buildTests -> openblas != null;
let
latex = lib.optionalAttrs buildDocs texlive.combine {
inherit (texlive) scheme-small

View File

@ -10,12 +10,10 @@
, rocm-smi
, hip
, gtest
, chrpath ? null
, chrpath
, buildTests ? false
}:
assert buildTests -> chrpath != null;
stdenv.mkDerivation (finalAttrs: {
pname = "rccl";
repoVersion = "2.12.10";

View File

@ -10,13 +10,13 @@
, rocm-comgr
, hip
, python3
, tensile ? null
, msgpack ? null
, libxml2 ? null
, llvm ? null
, python3Packages ? null
, gtest ? null
, gfortran ? null
, tensile
, msgpack
, libxml2
, llvm
, gtest
, gfortran
, python3Packages
, buildTensile ? true
, buildTests ? false
, buildBenchmarks ? false
@ -28,14 +28,6 @@
, gpuTargets ? [ "all" ]
}:
assert buildTensile -> tensile != null;
assert buildTensile -> msgpack != null;
assert buildTensile -> libxml2 != null;
assert buildTensile -> llvm != null;
assert buildTensile -> python3Packages != null;
assert buildTests -> gtest != null;
assert buildTests -> gfortran != null;
# Tests and benchmarks are a can of worms that I will tackle in a different PR
# It involves completely rewriting the amd-blis derivation
assert buildTests == false;

View File

@ -10,21 +10,15 @@
, hip
, sqlite
, python3
, gtest ? null
, boost ? null
, fftw ? null
, fftwFloat ? null
, llvmPackages ? null
, gtest
, boost
, fftw
, fftwFloat
, llvmPackages
, buildTests ? false
, buildBenchmarks ? false
}:
assert buildTests -> gtest != null;
assert buildBenchmarks -> fftw != null;
assert buildBenchmarks -> fftwFloat != null;
assert (buildTests || buildBenchmarks) -> boost != null;
assert (buildTests || buildBenchmarks) -> llvmPackages != null;
stdenv.mkDerivation (finalAttrs: {
pname = "rocfft";
repoVersion = "1.0.18";

View File

@ -8,15 +8,12 @@
, rocm-device-libs
, rocm-comgr
, hip
, gtest ? null
, gbenchmark ? null
, gtest
, gbenchmark
, buildTests ? false
, buildBenchmarks ? false
}:
assert buildTests -> gtest != null;
assert buildBenchmarks -> gbenchmark != null;
stdenv.mkDerivation (finalAttrs: {
pname = "rocprim";
repoVersion = "2.11.1";

View File

@ -8,15 +8,12 @@
, rocm-device-libs
, rocm-comgr
, hip
, gtest ? null
, gbenchmark ? null
, gtest
, gbenchmark
, buildTests ? false
, buildBenchmarks ? false
}:
assert buildTests -> gtest != null;
assert buildBenchmarks -> gbenchmark != null;
stdenv.mkDerivation (finalAttrs: {
pname = "rocrand";
repoVersion = "2.10.15";

View File

@ -12,17 +12,13 @@
, hip
, gfortran
, git
, gtest ? null
, boost ? null
, python3Packages ? null
, gtest
, boost
, python3Packages
, buildTests ? false
, buildBenchmarks ? false # Seems to depend on tests
}:
assert (buildTests || buildBenchmarks) -> gtest != null;
assert (buildTests || buildBenchmarks) -> boost != null;
assert (buildTests || buildBenchmarks) -> python3Packages != null;
stdenv.mkDerivation (finalAttrs: {
pname = "rocsparse";
repoVersion = "2.3.2";

View File

@ -9,13 +9,11 @@
, rocm-comgr
, rocprim
, hip
, gtest ? null
, gtest
, buildTests ? false
, buildBenchmarks ? false
}:
assert buildTests -> gtest != null;
# Doesn't seem to work, thousands of errors compiling with no clear fix
# Is this an upstream issue? We don't seem to be missing dependencies
assert buildTests == false;

View File

@ -6,25 +6,18 @@
, rocm-cmake
, hip
, openmp
, gtest ? null
, rocblas ? null
, texlive ? null
, doxygen ? null
, sphinx ? null
, python3Packages ? null
, gtest
, rocblas
, texlive
, doxygen
, sphinx
, python3Packages
, buildDocs ? true
, buildTests ? false
, buildSamples ? false
, gpuTargets ? [ ] # gpuTargets = [ "gfx908:xnack-" "gfx90a:xnack-" "gfx90a:xnack+" ... ]
}:
assert buildTests -> gtest != null;
assert buildTests -> rocblas != null;
assert buildDocs -> texlive != null;
assert buildDocs -> doxygen != null;
assert buildDocs -> sphinx != null;
assert buildDocs -> python3Packages != null;
# Building tests isn't working for now
# undefined reference to symbol '_ZTIN7testing4TestE'
assert buildTests == false;