From 60a7f5155487f122c7674dbdc2911e5d48c12907 Mon Sep 17 00:00:00 2001 From: David Knaack Date: Wed, 6 Mar 2024 13:57:43 +0100 Subject: [PATCH 1/2] syncthingtray: move app to `/Applications` & add binary to `/bin` --- pkgs/applications/misc/syncthingtray/default.nix | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/misc/syncthingtray/default.nix b/pkgs/applications/misc/syncthingtray/default.nix index 0badd7997603..2fa002297f4f 100644 --- a/pkgs/applications/misc/syncthingtray/default.nix +++ b/pkgs/applications/misc/syncthingtray/default.nix @@ -76,8 +76,13 @@ stdenv.mkDerivation (finalAttrs: { export QT_QPA_PLATFORM=offscreen export QT_PLUGIN_PATH="${lib.getBin qtbase}/${qtbase.qtPluginPrefix}" ''; - # don't test --help on Darwin because output is .app - doInstallCheck = !stdenv.isDarwin; + postInstall = lib.optionalString stdenv.isDarwin '' + # put the app bundle into the proper place /Applications instead of /bin + mkdir -p $out/Applications + mv $out/bin/syncthingtray.app $out/Applications + # Make binary available in PATH like on other platforms + ln -s $out/Applications/syncthingtray.app/Contents/MacOS/syncthingtray $out/bin/syncthingtray + ''; installCheckPhase = '' $out/bin/syncthingtray --help | grep ${finalAttrs.version} ''; From 5e4af1995e611352d9d9a3d55e5506e2f14ea1d3 Mon Sep 17 00:00:00 2001 From: Doron Behar Date: Wed, 6 Mar 2024 16:00:16 +0200 Subject: [PATCH 2/2] syncthingtray: use qt6 by default --- pkgs/top-level/aliases.nix | 1 + pkgs/top-level/all-packages.nix | 11 +++++------ 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix index be6927bc33ed..70d5a363a355 100644 --- a/pkgs/top-level/aliases.nix +++ b/pkgs/top-level/aliases.nix @@ -1094,6 +1094,7 @@ mapAliases ({ swift-im = throw "swift-im has been removed as it is unmaintained and depends on deprecated Python 2 / Qt WebKit"; # Added 2023-01-06 swtpm-tpm2 = swtpm; # Added 2021-02-26 syncthing-cli = syncthing; # Added 2021-04-06 + syncthingtray-qt6 = syncthingtray; # Added 2024-03-06 ### T ### diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 0d8fdcc4fb66..e4dda8d13cc5 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -35239,18 +35239,17 @@ with pkgs; syncthing-tray = callPackage ../applications/misc/syncthing-tray { }; - syncthingtray = libsForQt5.callPackage ../applications/misc/syncthingtray { }; - syncthingtray-minimal = libsForQt5.callPackage ../applications/misc/syncthingtray { + syncthingtray = kdePackages.callPackage ../applications/misc/syncthingtray { + # renamed in KF5 -> KF6 + plasma-framework = kdePackages.libplasma; + }; + syncthingtray-minimal = syncthingtray.override { webviewSupport = false; jsSupport = false; kioPluginSupport = false; plasmoidSupport = false; systemdSupport = true; }; - syncthingtray-qt6 = kdePackages.callPackage ../applications/misc/syncthingtray { - # renamed in KF5 -> KF6 - plasma-framework = kdePackages.libplasma; - }; synergy = libsForQt5.callPackage ../applications/misc/synergy { stdenv = if stdenv.isDarwin then darwin.apple_sdk_11_0.stdenv else stdenv;