colin/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

doc/reviewing-contributions: Add points about patches

Browse Source 
A weaker version of https://github.com/NixOS/nixpkgs/pull/186484#issuecomment-1608960696
This commit is contained in:
Robert Hensing 2023-06-27 15:56:54 +02:00 committed by GitHub
parent bc152fd1c1
commit 4920af40fc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
doc/contributing/reviewing-contributions.chapter.md
View File

@ -62,6 +62,8 @@ Sample template for a package update review is provided below.
- [ ] package build on ARCHITECTURE
- [ ] executables tested on ARCHITECTURE
- [ ] all depending packages build
- [ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
- [ ] patches that are remotely available are fetched with `fetchpatch`
##### Possible improvements
@ -105,6 +107,7 @@ Sample template for a new package review is provided below.
- [ ] source is fetched using the appropriate function
- [ ] the list of `phases` is not overridden
- [ ] when a phase (like `installPhase`) is overridden it starts with `runHook preInstall` and ends with `runHook postInstall`.
- [ ] patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed
- [ ] patches that are remotely available are fetched with `fetchpatch`
##### Possible improvements