From 4a01ca36d6bfc133bc617e661916a81327c9bbc8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebasti=C3=A1n=20Mancilla?= <238528+smancill@users.noreply.github.com> Date: Thu, 14 Jul 2022 08:49:19 -0400 Subject: [PATCH] python3Packages.jupyterlab_server: fix build on darwin (#181426) * python3Packages.jupyterlab_server: fix build on darwin Disable failing test of dependency jupyter_server on darwin, and mark the package as unbroken. Closes #176525. * Update pkgs/development/python-modules/jupyter_server/default.nix Co-authored-by: Sandro --- pkgs/development/python-modules/jupyter_server/default.nix | 2 ++ pkgs/development/python-modules/jupyterlab_server/default.nix | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pkgs/development/python-modules/jupyter_server/default.nix b/pkgs/development/python-modules/jupyter_server/default.nix index a140e2930b31..96dc7e82bcab 100644 --- a/pkgs/development/python-modules/jupyter_server/default.nix +++ b/pkgs/development/python-modules/jupyter_server/default.nix @@ -77,6 +77,8 @@ buildPythonPackage rec { ] ++ lib.optionals stdenv.isDarwin [ # attempts to use trashcan, build env doesn't allow this "test_delete" + # test is presumable broken in sandbox + "test_authorized_requests" ]; disabledTestPaths = [ diff --git a/pkgs/development/python-modules/jupyterlab_server/default.nix b/pkgs/development/python-modules/jupyterlab_server/default.nix index fffaeca691d6..e3693b450d76 100644 --- a/pkgs/development/python-modules/jupyterlab_server/default.nix +++ b/pkgs/development/python-modules/jupyterlab_server/default.nix @@ -49,7 +49,6 @@ buildPythonPackage rec { __darwinAllowLocalNetworking = true; meta = with lib; { - broken = stdenv.isDarwin; description = "JupyterLab Server"; homepage = "https://jupyter.org"; license = licenses.bsdOriginal;