From a3cad4378eea8b3dfa7c27180acecc92c51f02d9 Mon Sep 17 00:00:00 2001 From: K900 Date: Sun, 30 Apr 2023 20:35:27 +0300 Subject: [PATCH 1/2] pkgs/build-support: call the right makeWrapper function from wrapProgram --- .../setup-hooks/make-binary-wrapper/make-binary-wrapper.sh | 2 +- pkgs/build-support/setup-hooks/make-wrapper.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/build-support/setup-hooks/make-binary-wrapper/make-binary-wrapper.sh b/pkgs/build-support/setup-hooks/make-binary-wrapper/make-binary-wrapper.sh index 5f759d323cf6..88a50befd732 100644 --- a/pkgs/build-support/setup-hooks/make-binary-wrapper/make-binary-wrapper.sh +++ b/pkgs/build-support/setup-hooks/make-binary-wrapper/make-binary-wrapper.sh @@ -67,7 +67,7 @@ wrapProgramBinary() { hidden="${hidden}_" done mv "$prog" "$hidden" - makeWrapper "$hidden" "$prog" --inherit-argv0 "${@:2}" + makeBinaryWrapper "$hidden" "$prog" --inherit-argv0 "${@:2}" } # Generate source code for the wrapper in such a way that the wrapper inputs diff --git a/pkgs/build-support/setup-hooks/make-wrapper.sh b/pkgs/build-support/setup-hooks/make-wrapper.sh index 84e5ecee2909..4932e934ec16 100644 --- a/pkgs/build-support/setup-hooks/make-wrapper.sh +++ b/pkgs/build-support/setup-hooks/make-wrapper.sh @@ -217,5 +217,5 @@ wrapProgramShell() { hidden="${hidden}_" done mv "$prog" "$hidden" - makeWrapper "$hidden" "$prog" --inherit-argv0 "${@:2}" + makeShellWrapper "$hidden" "$prog" --inherit-argv0 "${@:2}" } From a2332386df7415d048f8291c75d25e65868efa91 Mon Sep 17 00:00:00 2001 From: K900 Date: Sun, 30 Apr 2023 20:28:44 +0300 Subject: [PATCH 2/2] gnuplot-qt: fix wrapper --- pkgs/tools/graphics/gnuplot/default.nix | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkgs/tools/graphics/gnuplot/default.nix b/pkgs/tools/graphics/gnuplot/default.nix index 5f96eb9f8d22..c95ec79534eb 100644 --- a/pkgs/tools/graphics/gnuplot/default.nix +++ b/pkgs/tools/graphics/gnuplot/default.nix @@ -53,11 +53,18 @@ in CXXFLAGS = lib.optionalString (stdenv.isDarwin && withQt) "-std=c++11"; + # we'll wrap things ourselves + dontWrapGApps = true; + dontWrapQtApps = true; + + # binary wrappers don't support --run postInstall = lib.optionalString withX '' - wrapProgram $out/bin/gnuplot \ + wrapProgramShell $out/bin/gnuplot \ --prefix PATH : '${gnused}/bin' \ --prefix PATH : '${coreutils}/bin' \ --prefix PATH : '${fontconfig.bin}/bin' \ + "''${gappsWrapperArgs[@]}" \ + "''${qtWrapperArgs[@]}" \ --run '. ${./set-gdfontpath-from-fontconfig.sh}' '';