From 713369c44b1bcf17b5d2f209bb229656ce2613bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stanis=C5=82aw=20Pitucha?= Date: Sun, 23 Oct 2022 15:23:02 +1100 Subject: [PATCH] doc/contributing: Explicitly allow trivial changes by non-authors Discussed and proposed at https://discourse.nixos.org/t/rules-around-adding-to-someones-pr/22671/3 --- doc/contributing/reviewing-contributions.chapter.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/doc/contributing/reviewing-contributions.chapter.md b/doc/contributing/reviewing-contributions.chapter.md index 4452695a6f38..0e6a0dd5b530 100644 --- a/doc/contributing/reviewing-contributions.chapter.md +++ b/doc/contributing/reviewing-contributions.chapter.md @@ -302,6 +302,12 @@ Container system, boot system and library changes are some examples of the pull It is possible for community members that have enough knowledge and experience on a special topic to contribute by merging pull requests. +In case the PR is stuck waiting for the original author to apply a trivial +change (a typo, capitalisation change, etc.) and the author allowed the members +to modify the PR, consider applying it yourself. (or commit the existing review +suggestion) You should pay extra attention to make sure the addition doesn't go +against the idea of the original PR and would not be opposed by the author. +