From 7fb2aab0151067b4df1d374707d158254c63c6ec Mon Sep 17 00:00:00 2001 From: "Travis A. Everett" Date: Sat, 13 Apr 2024 12:58:44 -0500 Subject: [PATCH] bats: add bats-tested packages to passthru.tests It would have been ~easy for someone to update bats without noticing whether the update broke any packages that depend directly on the nixpkgs-packaged bats for their tests. (I'm phrasing this tediously because there are also some packages that vendor a copy of bats.) Hopefully this will make it easier to confirm future updates. --- pkgs/development/interpreters/bats/default.nix | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/pkgs/development/interpreters/bats/default.nix b/pkgs/development/interpreters/bats/default.nix index 3828ed8a0968..8591552d45dd 100644 --- a/pkgs/development/interpreters/bats/default.nix +++ b/pkgs/development/interpreters/bats/default.nix @@ -18,6 +18,11 @@ , makeWrapper , runCommand , doInstallCheck ? true +# packages that use bats (for update testing) +, bash-preexec +, kikit +, locate-dominating-file +, packcc }: resholve.mkDerivation rec { @@ -207,6 +212,16 @@ resholve.mkDerivation rec { touch $out ''; }); + + # to see when updates would break things, include packages + # that use nixpkgs' bats for testing (as long as they + # aren't massive builds) + inherit bash-preexec locate-dominating-file packcc; + resholve = resholve.tests.cli; + } // lib.optionalAttrs (!stdenv.isDarwin) { + # TODO: kikit's kicad dependency is marked broken on darwin atm + # may be able to fold this up if that resolves. + inherit kikit; }; meta = with lib; {