From 9ecd9e01e590ff2b872a7def08d8c4cd688585e5 Mon Sep 17 00:00:00 2001 From: Sophie Tauchert Date: Sun, 24 Mar 2024 16:45:04 +0100 Subject: [PATCH] python3Packages.nbdime: fix build for jupyter-server 2.13 see also the upstream issue for this: https://github.com/jupyter/nbdime/issues/749 --- pkgs/development/python-modules/nbdime/749.patch | 10 ++++++++++ pkgs/development/python-modules/nbdime/default.nix | 6 ++++++ 2 files changed, 16 insertions(+) create mode 100644 pkgs/development/python-modules/nbdime/749.patch diff --git a/pkgs/development/python-modules/nbdime/749.patch b/pkgs/development/python-modules/nbdime/749.patch new file mode 100644 index 000000000000..b88aec0f67e3 --- /dev/null +++ b/pkgs/development/python-modules/nbdime/749.patch @@ -0,0 +1,10 @@ +--- a/nbdime/webapp/nbdimeserver.py ++++ b/nbdime/webapp/nbdimeserver.py +@@ -388,6 +388,7 @@ + 'jinja2_env': env, + 'local_hostnames': ['localhost', '127.0.0.1'], + 'cookie_secret': base64.encodebytes(os.urandom(32)), # Needed even for an unsecured server. ++ 'allow_unauthenticated_access': True, + } + + try: diff --git a/pkgs/development/python-modules/nbdime/default.nix b/pkgs/development/python-modules/nbdime/default.nix index 3f58201e2c92..855192fa5ec5 100644 --- a/pkgs/development/python-modules/nbdime/default.nix +++ b/pkgs/development/python-modules/nbdime/default.nix @@ -31,6 +31,12 @@ buildPythonPackage rec { hash = "sha256-8adgwLAMG6m0lFwWzpJXfzk/tR0YTzUbdoW6boUCCY4="; }; + patches = [ + # this fixes the webserver (nbdiff-web) when jupyter-server >=2.13 is used + # see https://github.com/jupyter/nbdime/issues/749 + ./749.patch + ]; + nativeBuildInputs = [ hatch-jupyter-builder hatchling