Merge pull request #279260 from SuperSamus/multiPkgs-false-remove

treewide: remove `multiArch=false` and wrong usage of `extraPkgs`
This commit is contained in:
Atemu 2024-05-14 09:59:43 +02:00 committed by GitHub
commit b4047a0455
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
46 changed files with 43 additions and 107 deletions

View File

@ -1,4 +1,4 @@
{ lib, fetchurl, appimageTools, pkgs }:
{ lib, fetchurl, appimageTools }:
let
pname = "plexamp";
@ -16,9 +16,6 @@ let
in appimageTools.wrapType2 {
inherit pname version src;
multiArch = false; # no 32bit needed
extraPkgs = pkgs: appimageTools.defaultFhsEnvArgs.multiPkgs pkgs ++ [ pkgs.bash ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/plexamp.desktop $out/share/applications/plexamp.desktop
install -m 444 -D ${appimageContents}/plexamp.png \

View File

@ -1,5 +1,4 @@
{ lib, appimageTools, fetchurl, makeDesktopItem
}:
{ lib, appimageTools, fetchurl, makeDesktopItem }:
let
pname = "MyCrypto";
@ -24,12 +23,9 @@ let
categories = [ "Finance" ];
};
in appimageTools.wrapType2 rec {
in appimageTools.wrapType2 {
inherit pname version src;
multiArch = false; # no p32bit needed
extraPkgs = appimageTools.defaultFhsEnvArgs.multiPkgs;
extraInstallCommands = ''
mkdir -p $out/share
cp -rt $out/share ${desktopItem}/share/applications ${appimageContents}/usr/share/icons

View File

@ -18,7 +18,7 @@ in
appimageTools.wrapType2 {
inherit pname version src;
extraPkgs = pkgs: with pkgs; [vulkan-headers vulkan-loader];
extraPkgs = pkgs: [ pkgs.vulkan-headers pkgs.vulkan-loader ];
extraInstallCommands = ''
mkdir -p $out/share/{applications,pixmaps}

View File

@ -28,9 +28,7 @@ appimageTools.wrapAppImage rec {
# taken from
# https://github.com/Dygmalab/Bazecor/blob/v1.3.11/src/main/utils/udev.ts#L6
extraPkgs = p: (appimageTools.defaultFhsEnvArgs.multiPkgs p) ++ [
p.glib
];
extraPkgs = pkgs: [ pkgs.glib ];
# Also expose the udev rules here, so it can be used as:
# services.udev.packages = [ pkgs.bazecor ];

View File

@ -12,7 +12,7 @@ let
in appimageTools.wrapType2 {
inherit pname version src;
extraPkgs = pkgs: (appimageTools.defaultFhsEnvArgs.multiPkgs pkgs) ++ [ pkgs.libsecret ];
extraPkgs = pkgs: [ pkgs.libsecret ];
extraInstallCommands = ''
mkdir -p $out/share/applications $out/share/pixmaps

View File

@ -14,7 +14,7 @@ in
appimageTools.wrapType2 {
inherit pname src version;
extraPkgs = pkgs: with pkgs; [ R zlib libusb-compat-0_1 ];
extraPkgs = pkgs: [ pkgs.R pkgs.zlib pkgs.libusb-compat-0_1 ];
extraInstallCommands = ''
mv $out/bin/${pname} $out/bin/GoldenCheetah

View File

@ -49,8 +49,6 @@ let
export LC_ALL=C.UTF-8
'';
multiArch = false; # no 32bit needed
extraPkgs = appimageTools.defaultFhsEnvArgs.multiPkgs;
extraInstallCommands = ''
source "${makeWrapper}/nix-support/setup-hook"
wrapProgram $out/bin/${pname} \

View File

@ -20,11 +20,7 @@ appimageTools.wrapType2 rec {
export LC_ALL=C.UTF-8
'';
multiArch = false; # no 32bit needed
extraPkgs = p: (appimageTools.defaultFhsEnvArgs.multiPkgs p) ++ [
p.libsecret
p.xorg.libxkbfile
];
extraPkgs = pkgs: [ pkgs.libsecret pkgs.xorg.libxkbfile ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/marktext.desktop $out/share/applications/marktext.desktop

View File

@ -13,7 +13,7 @@ let
in appimageTools.wrapType2 {
inherit name src;
extraPkgs = pkgs: (appimageTools.defaultFhsEnvArgs.multiPkgs pkgs) ++ [ pkgs.libsecret ];
extraPkgs = pkgs: [ pkgs.libsecret ];
extraInstallCommands = ''
mv $out/bin/${name} $out/bin/${pname}

View File

@ -12,7 +12,7 @@ let
in appimageTools.wrapType2 {
inherit pname version src;
extraPkgs = pkgs: with pkgs; [ libsecret ];
extraPkgs = pkgs: [ pkgs.libsecret ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/${pname}.desktop -t $out/share/applications

View File

@ -13,8 +13,6 @@ let
appimageContents = appimageTools.extract {
inherit pname version src;
};
nativeBuildInputs = [ makeWrapper ];
in
appimageTools.wrapType2 rec {
@ -24,8 +22,8 @@ appimageTools.wrapType2 rec {
export LC_ALL=C.UTF-8
'';
multiArch = false; # no 32bit needed
extraPkgs = p: (appimageTools.defaultFhsEnvArgs.multiPkgs p) ++ [ p.at-spi2-atk p.at-spi2-core ];
extraPkgs = pkgs: [ pkgs.at-spi2-atk pkgs.at-spi2-core ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/notable.desktop $out/share/applications/notable.desktop
install -m 444 -D ${appimageContents}/usr/share/icons/hicolor/1024x1024/apps/notable.png \

View File

@ -48,8 +48,6 @@ let
export LC_ALL=C.UTF-8
'';
multiPkgs = null; # no 32bit needed
extraPkgs = appimageTools.defaultFhsEnvArgs.multiPkgs;
extraInstallCommands = ''
install -Dm444 ${appimageContents}/notesnook.desktop -t $out/share/applications
install -Dm444 ${appimageContents}/notesnook.png -t $out/share/pixmaps

View File

@ -22,9 +22,7 @@ in appimageTools.wrapAppImage {
inherit pname version;
src = appimageContents;
extraPkgs = { pkgs, ... }@args: [
pkgs.hidapi
] ++ appimageTools.defaultFhsEnvArgs.multiPkgs args;
extraPkgs = pkgs: [ pkgs.hidapi ];
extraInstallCommands = ''
# Add desktop convencience stuff

View File

@ -1,6 +1,6 @@
{ callPackage, texliveMedium }:
{ callPackage }:
builtins.mapAttrs (pname: attrs: callPackage ./generic.nix (attrs // { inherit pname; inherit texliveMedium; })) {
builtins.mapAttrs (pname: attrs: callPackage ./generic.nix (attrs // { inherit pname; })) {
zettlr = {
version = "3.0.2";
hash = "sha256-xwBq+kLmTth15uLiYWJOhi/YSPZVJNO6JTrKFojSDXA=";

View File

@ -4,8 +4,6 @@
, appimageTools
, lib
, fetchurl
, texliveMedium
, pandoc
}:
# Based on https://gist.github.com/msteen/96cb7df66a359b827497c5269ccbbf94 and joplin-desktop nixpkgs.
@ -21,8 +19,8 @@ in
appimageTools.wrapType2 rec {
inherit pname version src;
multiArch = false; # no 32bit needed
extraPkgs = pkgs: (appimageTools.defaultFhsEnvArgs.multiPkgs pkgs) ++ [ texliveMedium pandoc ];
extraPkgs = pkgs: [ pkgs.texliveMedium pkgs.pandoc ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/Zettlr.desktop $out/share/applications/Zettlr.desktop
install -m 444 -D ${appimageContents}/Zettlr.png $out/share/icons/hicolor/512x512/apps/Zettlr.png

View File

@ -17,9 +17,6 @@ appimageTools.wrapType2 rec {
export LC_ALL=C.UTF-8
'';
multiArch = false; # no 32bit needed
extraPkgs = appimageTools.defaultFhsEnvArgs.multiPkgs;
meta = with lib; {
description = "Sylk WebRTC client";
homepage = "https://sylkserver.com/";

View File

@ -16,8 +16,7 @@ let
in appimageTools.wrapType2 {
inherit pname src version;
multiArch = false;
extraPkgs = pkgs: appimageTools.defaultFhsEnvArgs.multiPkgs pkgs ++ [ pkgs.bash ];
extraPkgs = pkgs: [ pkgs.bash ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/${pname}.desktop $out/share/applications/${pname}.desktop

View File

@ -1,4 +1,4 @@
{ lib, stdenv, pname, version, src, meta, appimageTools, makeWrapper, nss_latest }:
{ pname, version, src, meta, appimageTools, makeWrapper }:
let
name = "${pname}-${version}";
@ -25,5 +25,5 @@ appimageTools.wrapType2 {
--replace 'Exec=AppRun' 'Exec=${pname}'
'';
extraPkgs = _: [ nss_latest ];
extraPkgs = pkgs: [ pkgs.nss_latest ];
}

View File

@ -2,7 +2,6 @@
, stdenvNoCC
, fetchurl
, appimageTools
, libsecret
, makeWrapper
, writeShellApplication
, curl
@ -19,7 +18,7 @@ let
};
appimage = appimageTools.wrapType2 {
inherit version pname src;
extraPkgs = pkgs: with pkgs; [ libsecret ];
extraPkgs = pkgs: [ pkgs.libsecret ];
};
appimageContents = appimageTools.extractType2 {
inherit version pname src;

View File

@ -1,5 +1,4 @@
{ lib
, fetchurl
{ fetchurl
, appimageTools
, xorg
, pname
@ -27,8 +26,6 @@ in
export LC_ALL=C.UTF-8
'';
extraPkgs = pkgs: appimageTools.defaultFhsEnvArgs.multiPkgs pkgs;
extraInstallCommands = ''
mkdir -p $out/share
"${xorg.lndir}/bin/lndir" -silent "${extracted}/usr/share" "$out/share"

View File

@ -30,7 +30,7 @@ appimageTools.wrapType2 {
install -Dm644 ${desktopItem}/share/applications/* $out/share/applications
'';
extraPkgs = pkgs: with pkgs; [ procps ];
extraPkgs = pkgs: [ pkgs.procps ];
meta = with lib; {
description = "Workspace Simplifier - a cross-platform application organizing web services into Workspaces similar to browser profiles";

View File

@ -16,7 +16,7 @@ let
in appimageTools.wrapType2 {
inherit pname version src;
extraPkgs = pkgs: with pkgs; [ at-spi2-core ];
extraPkgs = pkgs: [ pkgs.at-spi2-core ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/irccloud.desktop $out/share/applications/irccloud.desktop

View File

@ -1,4 +1,4 @@
{ appimageTools, lib, fetchurl, libsecret }:
{ appimageTools, lib, fetchurl }:
let
pname = "electron-mail";
@ -20,9 +20,9 @@ in appimageTools.wrapType2 {
cp -r ${appimageContents}/usr/share/icons $out/share
'';
extraPkgs = pkgs: with pkgs; [
libsecret
libappindicator-gtk3
extraPkgs = pkgs: [
pkgs.libsecret
pkgs.libappindicator-gtk3
];
meta = with lib; {

View File

@ -12,7 +12,7 @@ appimageTools.wrapType2 rec {
hash = "sha256-D7qWwIFuCJmBvfdgf4Dsd2/jvi39tbAttaHOwLND4DY=";
};
extraPkgs = pkgs: (appimageTools.defaultFhsEnvArgs.multiPkgs pkgs) ++ [ pkgs.libsecret ];
extraPkgs = pkgs: [ pkgs.libsecret ];
extraInstallCommands =
let appimageContents = appimageTools.extract { inherit pname version src; };

View File

@ -19,8 +19,6 @@ in appimageTools.wrapType2 rec {
export LC_ALL=C.UTF-8
'';
multiArch = false;
extraPkgs = appimageTools.defaultFhsEnvArgs.multiPkgs;
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/browserx.desktop $out/share/applications/browserx.desktop
install -m 444 -D ${appimageContents}/usr/share/icons/hicolor/512x512/apps/browserx.png \

View File

@ -1,7 +1,6 @@
{ lib
, fetchurl
, appimageTools
, libsecret
}:
let
@ -19,9 +18,7 @@ let
in appimageTools.wrapType2 rec {
inherit pname version src;
extraPkgs = pkgs: with pkgs; [
libsecret
];
extraPkgs = pkgs: [ pkgs.libsecret ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/timeular.desktop $out/share/applications/timeular.desktop

View File

@ -31,8 +31,6 @@ in appimageTools.wrapType2 rec {
export LC_ALL=C.UTF-8
'';
multiArch = false; # no 32bit needed
extraPkgs = appimageTools.defaultFhsEnvArgs.multiPkgs;
extraInstallCommands = ''
mkdir "$out/share"
ln -s "${desktopItem}/share/applications" "$out/share/"

View File

@ -15,9 +15,7 @@ appimageTools.wrapAppImage rec {
};
# At runtime, Lbry likes to have access to Ffmpeg
extraPkgs = pkgs: with pkgs; [
ffmpeg
];
extraPkgs = pkgs: [ pkgs.ffmpeg ];
# General fixup
extraInstallCommands = ''

View File

@ -29,8 +29,6 @@ appimageTools.wrapType2 {
export LC_ALL=C.UTF-8
'';
extraPkgs = ps: appimageTools.defaultFhsEnvArgs.multiPkgs ps;
extraInstallCommands = ''
(
mkdir -p $out/share

View File

@ -40,7 +40,7 @@ rec {
wrapAppImage = args@{
src,
extraPkgs,
extraPkgs ? pkgs: [ ],
meta ? {},
...
}: buildFHSEnv

View File

@ -13,8 +13,7 @@ let
in appimageTools.wrapType2 {
inherit name src;
extraPkgs = pkgs: (appimageTools.defaultFhsEnvArgs.multiPkgs pkgs)
++ [ pkgs.libsecret ];
extraPkgs = pkgs: [ pkgs.libsecret ];
extraInstallCommands = ''
mv $out/bin/${name} $out/bin/${pname}

View File

@ -23,7 +23,7 @@ appimageTools.wrapType2 {
substituteInPlace $out/share/applications/${pname}.desktop --replace-fail 'Exec=AppRun --no-sandbox %U' 'Exec=${pname} %U'
'';
extraPkgs = pkgs: with pkgs; [ libsecret ];
extraPkgs = pkgs: [ pkgs.libsecret ];
meta = with lib; {
description = "Open-source electronics prototyping platform";

View File

@ -16,7 +16,7 @@ let
in appimageTools.wrapType2 {
inherit pname src version;
extraPkgs = pkgs: (appimageTools.defaultFhsEnvArgs.multiPkgs pkgs) ++ [ pkgs.libthai ];
extraPkgs = pkgs: [ pkgs.libthai ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/caido.desktop -t $out/share/applications

View File

@ -14,8 +14,7 @@ let
in appimageTools.wrapType2 rec {
inherit name pname src;
multiArch = false;
extraPkgs = p: (appimageTools.defaultFhsEnvArgs.multiPkgs p) ++ [ p.glib ];
extraPkgs = pkgs: [ pkgs.glib ];
# Also expose the udev rules here, so it can be used as:
# services.udev.packages = [ pkgs.chrysalis ];

View File

@ -62,9 +62,6 @@ if stdenv.isDarwin then stdenv.mkDerivation
else appimageTools.wrapType2 {
inherit pname version src meta;
extraPkgs = pkgs:
appimageTools.defaultFhsEnvArgs.multiPkgs pkgs;
extraInstallCommands =
let
appimageContents = appimageTools.extractType2 { inherit pname version src; };

View File

@ -35,7 +35,6 @@ let
appimage = appimageTools.wrapAppImage {
inherit pname version;
src = appimageContents;
extraPkgs = pkgs: (appimageTools.defaultFhsEnvArgs.targetPkgs pkgs);
};
in
stdenv.mkDerivation {

View File

@ -16,7 +16,7 @@ in
appimageTools.wrapType2 {
inherit meta pname version src;
extraPkgs = pkgs: (appimageTools.defaultFhsEnvArgs.multiPkgs pkgs) ++ [ pkgs.ocl-icd ];
extraPkgs = pkgs: [ pkgs.ocl-icd ];
extraInstallCommands = ''
mkdir -p $out/share/applications

View File

@ -31,8 +31,6 @@ in
appimageTools.wrapType2 {
inherit pname version src;
extraPkgs = pkgs: [ ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/${pname}.desktop $out/share/applications/${pname}.desktop
install -m 444 -D ${appimageContents}/${pname}.png $out/share/icons/hicolor/1024x1024/apps/${pname}.png

View File

@ -58,9 +58,9 @@ if stdenv.isDarwin then stdenv.mkDerivation {
} else appimageTools.wrapType2 {
inherit pname version src meta;
extraPkgs = ps: (appimageTools.defaultFhsEnvArgs.multiPkgs ps) ++ [
extraPkgs = pkgs: [
# Required to run DynamoDB locally
ps.jdk21
pkgs.jdk21
];
extraInstallCommands = let

View File

@ -20,9 +20,7 @@ let
in appimageTools.wrapType2 {
inherit pname version src;
extraPkgs = pkgs: with pkgs; [
segger-jlink
];
extraPkgs = pkgs: [ pkgs.segger-jlink ];
extraInstallCommands = ''
install -Dm444 ${appimageContents}/nrfconnect.desktop -t $out/share/applications

View File

@ -19,10 +19,6 @@ let
in appimageTools.wrapType2 {
inherit pname version src;
extraPkgs = pkgs: with pkgs; [
makeWrapper
];
extraBwrapArgs = [
"--setenv _JAVA_AWT_WM_NONREPARENTING 1"
];

View File

@ -57,8 +57,7 @@ if stdenv.isDarwin then stdenv.mkDerivation
else appimageTools.wrapType2 {
inherit pname version src meta passthru;
extraPkgs = pkgs:
(appimageTools.defaultFhsEnvArgs.multiPkgs pkgs) ++ [ pkgs.libthai ];
extraPkgs = pkgs: [ pkgs.libthai ];
extraInstallCommands =
let

View File

@ -14,7 +14,6 @@ buildFHSEnv {
pyserial
]))
]);
multiArch = false;
extraInstallCommands = ''
${lib.optionalString withGui ''

View File

@ -21,9 +21,6 @@ appimageTools.wrapType2 {
export LC_ALL=C.UTF-8
'';
multiArch = false; # no 32bit needed
extraPkgs = pkgs: appimageTools.defaultFhsEnvArgs.multiPkgs pkgs ++ [ pkgs.bash ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/${pname}.desktop $out/share/applications/${pname}.desktop
install -m 444 -D ${appimageContents}/${pname}.png \

View File

@ -28,10 +28,7 @@ in appimageTools.wrapAppImage {
inherit pname version;
src = appimageContents;
multiArch = false; # no 32bit needed
extraPkgs = { pkgs, ... }@args: [
pkgs.hidapi
] ++ appimageTools.defaultFhsEnvArgs.multiPkgs args;
extraPkgs = pkgs: [ pkgs.hidapi ];
extraInstallCommands = ''
# Add desktop convencience stuff

View File

@ -12,7 +12,7 @@ let
in appimageTools.wrapType2 {
inherit pname src version;
extraPkgs = pkgs: (appimageTools.defaultFhsEnvArgs.multiPkgs pkgs) ++ [ pkgs.libsecret ];
extraPkgs = pkgs: [ pkgs.libsecret ];
extraInstallCommands = ''
install -m 444 -D ${appimageContents}/buttercup.desktop -t $out/share/applications