From bbea3741fc6ad8c26dc6e3689f7d1732e06d90e3 Mon Sep 17 00:00:00 2001 From: Tomas Antonio Lopez Date: Wed, 23 Jun 2021 12:44:20 +0900 Subject: [PATCH] jquake: discard debug messages by default JQuake outputs too frequent debug-like messages to stdout, filling system logs quickly. --- pkgs/applications/misc/jquake/default.nix | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkgs/applications/misc/jquake/default.nix b/pkgs/applications/misc/jquake/default.nix index eccd8b4c1896..2a3f1aec4136 100644 --- a/pkgs/applications/misc/jquake/default.nix +++ b/pkgs/applications/misc/jquake/default.nix @@ -1,4 +1,6 @@ -{ lib, stdenv, fetchurl, copyDesktopItems, makeDesktopItem, unzip, jre8 }: +{ lib, stdenv, fetchurl, copyDesktopItems, makeDesktopItem, unzip, jre8 +, logOutput ? false +}: stdenv.mkDerivation rec { pname = "jquake"; @@ -14,10 +16,9 @@ stdenv.mkDerivation rec { sourceRoot = "."; postPatch = '' - # JQuake emits a lot of debug-like messages in console, but I - # don't think it's in our interest to void them by default. Log them at - # the appropriate level. - sed -i "/^java/ s/$/\ | logger -p user.debug/" JQuake.sh + # JQuake emits a lot of debug-like messages on stdout. Either drop the output + # stream entirely or log them at 'user.debug' level. + sed -i "/^java/ s/$/ ${if logOutput then "| logger -p user.debug" else "> \\/dev\\/null"}/" JQuake.sh # By default, an 'errors.log' file is created in the current directory. # cd into a temporary directory and let it be created there.