Merge pull request #195934 from vcunat/p/bpftools_strip-binary-name

bpftools: strip path to the binary from prints
This commit is contained in:
Jörg Thalheim 2022-10-14 13:28:43 +02:00 committed by GitHub
commit c3ee9d1583
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 0 deletions

View File

@ -15,6 +15,8 @@ stdenv.mkDerivation rec {
sha256 = "sha256-xDalSMcxLOb8WjRyy+rYle749ShB++fHH9jki9/isLo=";
};
patches = [ ./strip-binary-name.patch ];
nativeBuildInputs = [ python3 bison flex ];
buildInputs = (if (lib.versionAtLeast version "5.20")
then [ libopcodes libbfd ]

View File

@ -0,0 +1,15 @@
Strip path to the binary from prints.
I see no sense in including the full path in outputs like bpftool --version
Especially as argv[0] may not include it, based on calling via $PATH or not.
--- a/tools/bpf/bpftool/main.c
+++ b/tools/bpf/bpftool/main.c
@@ -443 +443,7 @@
- bin_name = argv[0];
+ /* Strip the path if any. */
+ const char *bin_name_slash = strrchr(argv[0], '/');
+ if (bin_name_slash) {
+ bin_name = bin_name_slash + 1;
+ } else {
+ bin_name = argv[0];
+ }