From c77d192eb4860347f8050b11b73fbe23cce788cd Mon Sep 17 00:00:00 2001 From: Martin Weinelt Date: Thu, 21 Mar 2024 06:16:33 +0100 Subject: [PATCH] prometheus-kea-exporter: 0.6.1 -> 0.7.0 https://github.com/mweinelt/kea-exporter/blob/v0.7.0/HISTORY Updates the module to use the target name, because it now supports both UDS as well as HTTP URLs. --- .../monitoring/prometheus/exporters/kea.nix | 21 +++++++++++-------- .../monitoring/prometheus/kea-exporter.nix | 4 ++-- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/nixos/modules/services/monitoring/prometheus/exporters/kea.nix b/nixos/modules/services/monitoring/prometheus/exporters/kea.nix index 0214c5ec8e30..ccfdd98b8db9 100644 --- a/nixos/modules/services/monitoring/prometheus/exporters/kea.nix +++ b/nixos/modules/services/monitoring/prometheus/exporters/kea.nix @@ -1,7 +1,7 @@ { config , lib , pkgs -, options +, utils , ... }: @@ -10,18 +10,22 @@ with lib; let cfg = config.services.prometheus.exporters.kea; in { + imports = [ + (mkRenamedOptionModule [ "controlSocketPaths" ] [ "targets" ]) + ]; port = 9547; extraOpts = { - controlSocketPaths = mkOption { + targets = mkOption { type = types.listOf types.str; example = literalExpression '' [ "/run/kea/kea-dhcp4.socket" "/run/kea/kea-dhcp6.socket" + "http://127.0.0.1:8547" ] ''; description = lib.mdDoc '' - Paths to kea control sockets + Paths or URLs to the Kea control socket. ''; }; }; @@ -33,12 +37,11 @@ in { serviceConfig = { User = "kea"; DynamicUser = true; - ExecStart = '' - ${pkgs.prometheus-kea-exporter}/bin/kea-exporter \ - --address ${cfg.listenAddress} \ - --port ${toString cfg.port} \ - ${concatStringsSep " " cfg.controlSocketPaths} - ''; + ExecStart = utils.escapeSystemdExecArgs ([ + (lib.getExe pkgs.prometheus-kea-exporter) + "--address" cfg.listenAddress + "--port" cfg.port + ] ++ cfg.extraFlags ++ cfg.targets); RuntimeDirectory = "kea"; RuntimeDirectoryPreserve = true; RestrictAddressFamilies = [ diff --git a/pkgs/servers/monitoring/prometheus/kea-exporter.nix b/pkgs/servers/monitoring/prometheus/kea-exporter.nix index 721f69763fc0..b7d7d1d7c6d3 100644 --- a/pkgs/servers/monitoring/prometheus/kea-exporter.nix +++ b/pkgs/servers/monitoring/prometheus/kea-exporter.nix @@ -6,13 +6,13 @@ python3Packages.buildPythonApplication rec { pname = "kea-exporter"; - version = "0.6.1"; + version = "0.7.0"; format = "pyproject"; src = fetchPypi { pname = "kea_exporter"; inherit version; - hash = "sha256-PyNFSTDqT+PBY7d9NSG1FVhN+Y3ID13T6859kBYsFzU="; + hash = "sha256-kn2iwYWcyW90tgfWmzLF7rU06fJyLRzqYKNLOgu/Yqk="; }; nativeBuildInputs = with python3Packages; [