From 28179dd8942b0d98e4c79153ea54001b53866a78 Mon Sep 17 00:00:00 2001 From: Nick Cao Date: Sun, 31 Mar 2024 09:50:24 -0400 Subject: [PATCH 1/3] python311Packages.flask-admin: add nickcao to maintainers --- pkgs/development/python-modules/flask-admin/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/python-modules/flask-admin/default.nix b/pkgs/development/python-modules/flask-admin/default.nix index c4d686c01478..4e2c3c833ed1 100644 --- a/pkgs/development/python-modules/flask-admin/default.nix +++ b/pkgs/development/python-modules/flask-admin/default.nix @@ -120,6 +120,6 @@ buildPythonPackage rec { homepage = "https://github.com/flask-admin/flask-admin/"; changelog = "https://github.com/flask-admin/flask-admin/releases/tag/v${version}"; license = licenses.bsd3; - maintainers = with maintainers; [ ]; + maintainers = with maintainers; [ nickcao ]; }; } From ba5cd1ccfdcd458f8ffa6c4a711ca9c3044e3487 Mon Sep 17 00:00:00 2001 From: Nick Cao Date: Sun, 31 Mar 2024 09:53:26 -0400 Subject: [PATCH 2/3] python311Packages.flask-admin: fetch source from github --- .../python-modules/flask-admin/default.nix | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pkgs/development/python-modules/flask-admin/default.nix b/pkgs/development/python-modules/flask-admin/default.nix index 4e2c3c833ed1..5157ee0cc490 100644 --- a/pkgs/development/python-modules/flask-admin/default.nix +++ b/pkgs/development/python-modules/flask-admin/default.nix @@ -7,7 +7,7 @@ , email-validator , enum34 , fetchpatch -, fetchPypi +, fetchFromGitHub , flask , flask-babelex , flask-mongoengine @@ -34,10 +34,11 @@ buildPythonPackage rec { disabled = pythonOlder "3.8"; - src = fetchPypi { - pname = "Flask-Admin"; - inherit version; - hash = "sha256-JMrir4MramEaAdfcNfQtJmwdbHWkJrhp2MskG3gjM2k="; + src = fetchFromGitHub { + owner = "flask-admin"; + repo = "flask-admin"; + rev = "refs/tags/v${version}"; + hash = "sha256-L8Q9uPpoen6ZvuF2bithCMSgc6X5khD1EqH2FJPspZc="; }; patches = [ From a41d4c10cc9e097d28ba138da88108a85387dfb9 Mon Sep 17 00:00:00 2001 From: Nick Cao Date: Sun, 31 Mar 2024 10:06:45 -0400 Subject: [PATCH 3/3] python311Packages.flask-admin: modernize --- .../python-modules/flask-admin/default.nix | 79 +++++++------------ 1 file changed, 29 insertions(+), 50 deletions(-) diff --git a/pkgs/development/python-modules/flask-admin/default.nix b/pkgs/development/python-modules/flask-admin/default.nix index 5157ee0cc490..ae12e6353e2b 100644 --- a/pkgs/development/python-modules/flask-admin/default.nix +++ b/pkgs/development/python-modules/flask-admin/default.nix @@ -1,15 +1,10 @@ { lib -, arrow , azure-storage-blob , boto , buildPythonPackage -, colour -, email-validator -, enum34 , fetchpatch , fetchFromGitHub , flask -, flask-babelex , flask-mongoengine , flask-sqlalchemy , geoalchemy2 @@ -19,10 +14,9 @@ , pymongo , pytestCheckHook , pythonOlder +, setuptools , shapely , sqlalchemy -, sqlalchemy-citext -, sqlalchemy-utils , wtf-peewee , wtforms }: @@ -30,7 +24,7 @@ buildPythonPackage rec { pname = "flask-admin"; version = "1.6.1"; - format = "setuptools"; + pyproject = true; disabled = pythonOlder "3.8"; @@ -50,66 +44,51 @@ buildPythonPackage rec { }) ]; - propagatedBuildInputs = [ + build-system = [ + setuptools + ]; + + dependencies = [ flask wtforms ]; - passthru.optional-dependencies = { - aws = [ - boto - ]; - azure = [ - azure-storage-blob - ]; + optional-dependencies = { + aws = [ boto ]; + azure = [ azure-storage-blob ]; }; nativeCheckInputs = [ - arrow - colour - email-validator - flask-babelex + pillow + mongoengine + pymongo + wtf-peewee + sqlalchemy flask-mongoengine flask-sqlalchemy - geoalchemy2 - mongoengine - pillow - psycopg2 - pymongo - pytestCheckHook + # flask-babelex # broken and removed shapely - sqlalchemy - sqlalchemy-citext - sqlalchemy-utils - wtf-peewee - ]; - - disabledTests = [ - # Incompatible with werkzeug 2.1 - "test_mockview" - # Tests are outdated and don't work with peewee - "test_nested_flask_views" - "test_export_csv" - "test_list_row_actions" - "test_column_editable_list" - "test_column_filters" - "test_export_csv" + geoalchemy2 + psycopg2 + pytestCheckHook ]; disabledTestPaths = [ - # Tests have additional requirements - "flask_admin/tests/geoa/test_basic.py" - "flask_admin/tests/mongoengine/test_basic.py" - "flask_admin/tests/pymongo/test_basic.py" + # depends on flask-babelex "flask_admin/tests/sqla/test_basic.py" "flask_admin/tests/sqla/test_form_rules.py" - "flask_admin/tests/sqla/test_inlineform.py" + "flask_admin/tests/sqla/test_multi_pk.py" "flask_admin/tests/sqla/test_postgres.py" "flask_admin/tests/sqla/test_translation.py" - # RuntimeError: Working outside of application context. - "flask_admin/tests/sqla/test_multi_pk.py" - # Broken test + # broken + "flask_admin/tests/sqla/test_inlineform.py" + "flask_admin/tests/test_model.py" "flask_admin/tests/fileadmin/test_fileadmin.py" + # requires database + "flask_admin/tests/geoa/test_basic.py" + "flask_admin/tests/pymongo/test_basic.py" + "flask_admin/tests/mongoengine/test_basic.py" + "flask_admin/tests/peeweemodel/test_basic.py" ]; pythonImportsCheck = [