From d215163ff9d37bf3bac8024c84589ec82a1e70af Mon Sep 17 00:00:00 2001
From: Wanja Hentze <wanja.hentze@bevuta.com>
Date: Mon, 11 Apr 2022 18:36:55 +0200
Subject: [PATCH] nixos/cockroachdb: add `extraArgs` option

There are a bunch of args to `cockroach start` that simply can not be set
given the current set of options, so this escape hatch enables them.
---
 nixos/modules/services/databases/cockroachdb.nix | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/nixos/modules/services/databases/cockroachdb.nix b/nixos/modules/services/databases/cockroachdb.nix
index eb061af92621..411f2315f762 100644
--- a/nixos/modules/services/databases/cockroachdb.nix
+++ b/nixos/modules/services/databases/cockroachdb.nix
@@ -10,7 +10,8 @@ let
   ifNotNull = v: s: optionalString (v != null) s;
 
   startupCommand = lib.concatStringsSep " "
-    [ # Basic startup
+    ([
+      # Basic startup
       "${crdb}/bin/cockroach start"
       "--logtostderr"
       "--store=/var/lib/cockroachdb"
@@ -31,7 +32,7 @@ let
 
       # Certificate/security settings.
       (if cfg.insecure then "--insecure" else "--certs-dir=${cfg.certsDir}")
-    ];
+    ] ++ cfg.extraArgs);
 
     addressOption = descr: defaultPort: {
       address = mkOption {
@@ -159,6 +160,16 @@ in
           only contain open source features and open source code).
         '';
       };
+
+      extraArgs = mkOption {
+        type = types.listOf types.str;
+        default = [];
+        example = [ "--advertise-addr" "[fe80::f6f2:::]" ];
+        description = ''
+          Extra CLI arguments passed to <command>cockroach start</command>.
+          For the full list of supported argumemnts, check <link xlink:href="https://www.cockroachlabs.com/docs/stable/cockroach-start.html#flags"/>
+        '';
+      };
     };
   };