From dbbb1e5ee438cabbbc8f76beb2dc0928956394eb Mon Sep 17 00:00:00 2001
From: Fabian Affolter <mail@fabian-affolter.ch>
Date: Fri, 7 Oct 2022 16:51:58 +0200
Subject: [PATCH] python310Packages.pyreadstat: enable tests

- add pythonImportsCheck
- use module name
---
 .../python-modules/pyreadstat/default.nix     | 43 +++++++++++++++----
 pkgs/top-level/python-packages.nix            |  4 +-
 2 files changed, 37 insertions(+), 10 deletions(-)

diff --git a/pkgs/development/python-modules/pyreadstat/default.nix b/pkgs/development/python-modules/pyreadstat/default.nix
index 499aa97db8c7..4992d260471c 100644
--- a/pkgs/development/python-modules/pyreadstat/default.nix
+++ b/pkgs/development/python-modules/pyreadstat/default.nix
@@ -1,14 +1,26 @@
-{ lib, buildPythonPackage, fetchFromGitHub, cython, zlib, pandas, readstat }:
+{ lib
+, buildPythonPackage
+, cython
+, fetchFromGitHub
+, pandas
+, python
+, pythonOlder
+, readstat
+, zlib
+}:
 
 buildPythonPackage rec {
   pname = "pyreadstat";
   version = "1.1.9";
+  format = "setuptools";
+
+  disabled = pythonOlder "3.7";
 
   src = fetchFromGitHub {
     owner = "Roche";
     repo = "pyreadstat";
     rev = "v${version}";
-    sha256 = "16aa16ybh3ikmlxsg8zm19x9k6r4gpd0sxqagv318w76jjyw1nrs";
+    hash = "sha256-OtvAvZTmcBTGfgp3Ddp9JJuZegr1o6c7rTMOuLwJSpk=";
   };
 
   nativeBuildInputs = [
@@ -24,11 +36,26 @@ buildPythonPackage rec {
     pandas
   ];
 
-  meta = {
-    homepage = "https://github.com/Roche/pyreadstat";
-    description = "Python package to read SAS, SPSS and Stata files into pandas data frames using the readstat C library";
-    license = lib.licenses.asl20;
-    maintainers = with lib.maintainers; [ swflint ];
-  };
+  pythonImportsCheck = [
+    "pyreadstat"
+  ];
 
+  preCheck = ''
+    export HOME=$(mktemp -d);
+  '';
+
+  checkPhase = ''
+    runHook preCheck
+
+    ${python.interpreter} tests/test_basic.py
+
+    runHook postCheck
+  '';
+
+  meta = with lib; {
+    description = "Python package to read SAS, SPSS and Stata files into pandas data frames using the readstat C library";
+    homepage = "https://github.com/Roche/pyreadstat";
+    license = licenses.asl20;
+    maintainers = with maintainers; [ swflint ];
+  };
 }
diff --git a/pkgs/top-level/python-packages.nix b/pkgs/top-level/python-packages.nix
index 75cbf33b249e..f964503b7196 100644
--- a/pkgs/top-level/python-packages.nix
+++ b/pkgs/top-level/python-packages.nix
@@ -8413,6 +8413,8 @@ in {
 
   pyramid_multiauth = callPackage ../development/python-modules/pyramid_multiauth { };
 
+  pyreadstat = callPackage ../development/python-modules/pyreadstat { };
+
   pyrealsense2 = toPythonModule (pkgs.librealsense.override {
     enablePython = true;
     pythonPackages = self;
@@ -9564,8 +9566,6 @@ in {
 
   readme_renderer = callPackage ../development/python-modules/readme_renderer { };
 
-  readstats = callPackage ../development/python-modules/pyreadstat { };
-
   readthedocs-sphinx-ext = callPackage ../development/python-modules/readthedocs-sphinx-ext { };
 
   rebulk = callPackage ../development/python-modules/rebulk { };