From 351e96ff3f4d4338fdee6f740cccb3be41b23951 Mon Sep 17 00:00:00 2001 From: Aidan Gauland Date: Thu, 4 Apr 2024 11:35:41 +1300 Subject: [PATCH 1/3] jfrog-cli: specify passthru.updateScript --- pkgs/tools/misc/jfrog-cli/default.nix | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkgs/tools/misc/jfrog-cli/default.nix b/pkgs/tools/misc/jfrog-cli/default.nix index 3704cfed317c..c9f38bedc066 100644 --- a/pkgs/tools/misc/jfrog-cli/default.nix +++ b/pkgs/tools/misc/jfrog-cli/default.nix @@ -1,6 +1,7 @@ { lib , buildGoModule , fetchFromGitHub +, nix-update-script }: buildGoModule rec { @@ -24,6 +25,8 @@ buildGoModule rec { # Some of the tests require a writable $HOME preCheck = "export HOME=$TMPDIR"; + passthru.updateScript = nix-update-script { }; + meta = with lib; { homepage = "https://github.com/jfrog/jfrog-cli"; description = "Client for accessing to JFrog's Artifactory and Mission Control through their respective REST APIs"; From d5aa6c693c649c0d49f1af602a4402ad04ea25cf Mon Sep 17 00:00:00 2001 From: Aidan Gauland Date: Thu, 18 Apr 2024 17:03:52 +1200 Subject: [PATCH 2/3] jfrog-cli: 2.52.10 -> 2.56.0 --- pkgs/tools/misc/jfrog-cli/default.nix | 32 ++++++++++++++++++++++++--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/pkgs/tools/misc/jfrog-cli/default.nix b/pkgs/tools/misc/jfrog-cli/default.nix index c9f38bedc066..b322df701c8f 100644 --- a/pkgs/tools/misc/jfrog-cli/default.nix +++ b/pkgs/tools/misc/jfrog-cli/default.nix @@ -1,21 +1,45 @@ { lib , buildGoModule , fetchFromGitHub +, nodejs , nix-update-script }: buildGoModule rec { pname = "jfrog-cli"; - version = "2.52.10"; + version = "2.56.0"; src = fetchFromGitHub { owner = "jfrog"; repo = "jfrog-cli"; rev = "refs/tags/v${version}"; - hash = "sha256-sqKlYHOpjIxNff1QK540Xxqr7w+WZ+pZXgfAKjRbMuM="; + hash = "sha256-a7zCPyKV9kZ34XxVBYotcMvXUVrieunFpKGBK1Jhvo4="; }; - vendorHash = "sha256-Cm6Wu2U2i6WZfps1WLAjYuVZZ1y7J4WXFLmX2bkevd4="; + vendorHash = "sha256-q0PXbLTS5Po3xTK+CkU7BtZ6tk1PfH3zVAVK1IbmitY="; + + # Upgrade the Go version during the vendoring FOD build because it fails otherwise. + overrideModAttrs = _: { + preBuild = '' + substituteInPlace go.mod --replace-fail 'go 1.20' 'go 1.21' + ''; + postInstall = '' + cp go.mod "$out/go.mod" + ''; + }; + + # Copy the modified go.mod we got from the vendoring process. + preBuild = '' + cp vendor/go.mod go.mod + ''; + + postPatch = '' + # Patch out broken test cleanup. + substituteInPlace artifactory_test.go \ + --replace-fail \ + 'deleteReceivedReleaseBundle(t, "cli-tests", "2")' \ + '// deleteReceivedReleaseBundle(t, "cli-tests", "2")' + ''; postInstall = '' # Name the output the same way as the original build script does @@ -25,6 +49,8 @@ buildGoModule rec { # Some of the tests require a writable $HOME preCheck = "export HOME=$TMPDIR"; + nativeCheckInputs = [ nodejs ]; + passthru.updateScript = nix-update-script { }; meta = with lib; { From 706b9c23c9180733d732104b6e7220b9f941ff74 Mon Sep 17 00:00:00 2001 From: Aidan Gauland Date: Thu, 11 Apr 2024 15:01:45 +1200 Subject: [PATCH 3/3] jfrog-cli: add aidalgol as maintainer --- pkgs/tools/misc/jfrog-cli/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/tools/misc/jfrog-cli/default.nix b/pkgs/tools/misc/jfrog-cli/default.nix index b322df701c8f..cc778b6f6692 100644 --- a/pkgs/tools/misc/jfrog-cli/default.nix +++ b/pkgs/tools/misc/jfrog-cli/default.nix @@ -59,6 +59,6 @@ buildGoModule rec { changelog = "https://github.com/jfrog/jfrog-cli/releases/tag/v${version}"; license = licenses.asl20; mainProgram = "jf"; - maintainers = with maintainers; [ detegr ]; + maintainers = with maintainers; [ detegr aidalgol ]; }; }