colin/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gtk4: use mesonBool/mesonEnable for package options

Browse Source 
For package options, it's best to always set the Meson option based on
the value of the option, to avoid non-default option values breaking
when defaults change.  For example, this fixes disabling vulkanSupport
on Linux.
This commit is contained in:
Alyssa Ross 2024-04-28 19:00:50 +02:00
parent 0e395f4da1
commit e3e8de9334
No known key found for this signature in database
GPG Key ID: F9DBED4859B271C0
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pkgs/development/libraries/gtk/4.x.nix
View File

@ -169,18 +169,15 @@ stdenv.mkDerivation (finalAttrs: {
mesonFlags = [
# ../docs/tools/shooter.c:4:10: fatal error: 'cairo-xlib.h' file not found
"-Ddocumentation=${lib.boolToString x11Support}"
(lib.mesonBool "documentation" x11Support)
"-Dbuild-tests=false"
"-Dtracker=${if trackerSupport then "enabled" else "disabled"}"
"-Dbroadway-backend=${lib.boolToString broadwaySupport}"
] ++ lib.optionals vulkanSupport [
"-Dvulkan=enabled"
] ++ lib.optionals (!cupsSupport) [
"-Dprint-cups=disabled"
(lib.mesonEnable "tracker" trackerSupport)
(lib.mesonBool "broadway-backend" broadwaySupport)
(lib.mesonEnable "vulkan" vulkanSupport)
(lib.mesonEnable "print-cups" cupsSupport)
(lib.mesonBool "x11-backend" x11Support)
] ++ lib.optionals (stdenv.isDarwin && !stdenv.isAarch64) [
"-Dmedia-gstreamer=disabled" # requires gstreamer-gl
] ++ lib.optionals (!x11Support) [
"-Dx11-backend=false"
];
doCheck = false; # needs X11