colin/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

foot: use default priority (> ncurses prio in systemPackages)

Browse Source 
Why hasn't anybody told me that the higher the priority value the lower
the priority? The meta.priority value I chose for foot had the opposite
effect I intended. Priority 9 (as ncurses has in systemPackages) is just
one step higher in priority than lib.meta.lowPrio. Just using the
default priority (which for buildEnv equates to 5 although nix-env(1)
claims the default priority is 0) gets us the desired result:
foot.terminfo's files will overwrite any symlinks to ncurses.
This commit is contained in:
sternenseemann 2024-01-31 18:53:36 +01:00
parent df0f8b6eaf
commit f06714e0a5
1 changed files with 0 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkgs/applications/terminal-emulators/foot/default.nix
View File

@ -212,19 +212,6 @@ stdenv.mkDerivation {
license = licenses.mit;
maintainers = [ maintainers.sternenseemann maintainers.abbe ];
platforms = platforms.linux;
# From (presumably) ncurses version 6.3, it will ship a foot
# terminfo file. This however won't include some non-standard
# capabilities foot's bundled terminfo file contains. Unless we
# want to have some features in e. g. vim or tmux stop working,
# we need to make sure that the foot terminfo overwrites ncurses'
# one. Due to <nixpkgs/nixos/modules/config/system-path.nix>
# ncurses is always added to environment.systemPackages on
# NixOS with its priority increased by 3, so we need to go
# one bigger.
# This doesn't matter a lot for local use since foot sets
# TERMINFO to a store path, but allows installing foot.terminfo
# on remote systems for proper foot terminfo support.
priority = (ncurses.meta.priority or 5) + 3 + 1;
mainProgram = "foot";
};
}