colin/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gotools: update comments regarding gopls

Browse Source 
The replaced comment was stating some properties about upstream source
code that are no longer the case. The new comment mentions what's the
current situation in regards to the gopls binary.
This commit is contained in:
Roman Gonzalez 2020-06-02 11:31:54 -07:00
parent 467ce5a9f4
commit f0c032a4ae
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
pkgs/development/tools/gotools/default.nix
View File

@ -11,12 +11,16 @@ buildGoModule rec {
sha256 = "0a8c7j4w784w441j3j3bh640vy1g6g214641qv485wyi0xj49anf";
};
# Build of golang.org/x/tools/gopls fails with:
# can't load package: package golang.org/x/tools/gopls: unknown import path "golang.org/x/tools/gopls": cannot find module providing package golang.org/x/tools/gopls
# That is most probably caused by golang.org/x/tools/gopls containing a separate Go module.
# In order to fix this, we simply remove the module.
# Note that build of golang.org/x/tools/cmd/gopls provides identical binary as golang.org/x/tools/gopls.
# See https://github.com/NixOS/nixpkgs/pull/64335.
# The gopls folder has its own module definition which causes a build failure.
# Given that, we can't have the gopls binary be part of the gotools
# derivation.
#
# We have a seperate derivation to build the gopls tool.
#
# Related
#
# * https://github.com/NixOS/nixpkgs/pull/85868
# * https://github.com/NixOS/nixpkgs/issues/88716
postPatch = ''
rm -rf gopls
'';
@ -47,4 +51,4 @@ buildGoModule rec {
# Do not copy this without a good reason for enabling
# In this case tools is heavily coupled with go itself and embeds paths.
allowGoReference = true;
}
}