colin/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

buildRubyGem: Make testing easier

Browse Source 
Don't default `doCheck` to false,
and use the default set of phases
so the phases list does not need to be overriden
in order to add checkPhase or installCheckPhase.
This commit is contained in:
Aneesh Agrawal 2018-03-03 23:24:15 -08:00
parent 1aa59bfd3f
commit fced35fa44
1 changed files with 0 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pkgs/development/ruby-modules/gem/default.nix
View File

@ -36,7 +36,6 @@ lib.makeOverridable (
rubyName = builtins.parseDrvName ruby.name; rubyName = builtins.parseDrvName ruby.name;
in "${rubyName.name}${rubyName.version}-") in "${rubyName.name}${rubyName.version}-")
, buildInputs ? [] , buildInputs ? []
, doCheck ? false
, meta ? {} , meta ? {}
, patches ? [] , patches ? []
, gemPath ? [] , gemPath ? []
@ -79,7 +78,6 @@ in
stdenv.mkDerivation ((builtins.removeAttrs attrs ["source"]) // { stdenv.mkDerivation ((builtins.removeAttrs attrs ["source"]) // {
inherit ruby; inherit ruby;
inherit doCheck;
inherit dontBuild; inherit dontBuild;
inherit dontStrip; inherit dontStrip;
inherit type; inherit type;
@ -96,8 +94,6 @@ stdenv.mkDerivation ((builtins.removeAttrs attrs ["source"]) // {
inherit src; inherit src;
phases = attrs.phases or [ "unpackPhase" "patchPhase" "buildPhase" "installPhase" "fixupPhase" ];
unpackPhase = attrs.unpackPhase or '' unpackPhase = attrs.unpackPhase or ''
runHook preUnpack runHook preUnpack