Commit Graph

270 Commits

Author SHA1 Message Date
Léo Gaspard
211fee9c43
pull request template: cleanup (#117537)
Remove elements of the PR template that have a low signal/noise ratio,
and add one that I think would have a good signal/noise ratio.

-----
Remove:
Determined the impact on package closure size (by running `nix path-info
-S` before and after)
-----
Rationale:
This is rarely done in practice, and apart from for specific packages
this is usually not a good indicator of anything useful

It might make sense to re-introduce it with two holes to fill, but then
we would have to make a serious decision to never land without these two
numbers filled in or with too big a regression, because in practice this
box has been a no-op in many cases.

Maybe just integrating this check in nixpkgs-review would bring the most
benefit here?
-----

-----
Remove:
Ensured that relevant documentation is up to date
-----
Rationale:
This is fuzzy, “relevant documentation” is way too often hard to find
-----

-----
Add:
Added a release notes entry if the change is major or breaking
-----
Rationale:
This is way too often forgotten, and is also a self-contained easy task
-----
2021-05-21 03:06:21 +02:00
Jan Tojnar
6225647cfc
.github/workflows/merge-staging.yml: Include branch in comment
If I receive the mail notification that staging(-next) merge failed,
I either need to check `git log staging-next` or click the action run link
to find out where should I resolve the conflict.

To save time, let’s include the information about which step failed right in the comment.
2021-05-13 13:58:14 +02:00
Jan Tojnar
8a32c47586 .github/labeler.yml: Update GNOME file patterns
This got missed in the move (https://github.com/NixOS/nixpkgs/pull/122107) because it is in a “hidden” directory.
2021-05-12 19:38:41 +02:00
sternenseemann
ef9631e523 pkgs/top-level: init expression for haskell-updates jobset
release-haskell.nix is intended to be a replacement for
https://github.com/peti/ci/blob/master/haskell-nixpkgs.nix
which is currently the main expression for the haskell-updates jobset
on hydra (in the nixpkgs project).

It has the same jobs as the old haskell-nixpkgs.nix file:

* haskellPackages.*
* haskell.compiler.*
* Some extra haskell packages for certain compilers

The following jobs are new:

* tests.haskell.*
* A manually maintained list of top-level haskell packages (most of them
  using justStaticExecutables)
* An aggregate job which is intended to aid merging the haskell-updates
  branch: It holds an arbitrary list of haskell-related packages and
  tests we intend have working at all times. This is still somewhat
  incomplete and should be extendend in the future.

Additionally a lot of refactoring has been done and some unnecessary
code has been eliminated. Due to the increased set of jobs and my
ideas of convenience however, the code size has grown overall.
I've tried document the individual parts and would be happy about
feedback in general.

One future improvement could be making adding top-level haskell packages
more convenient and adding them all to the aggregate job automatically.
2021-05-03 11:40:03 +02:00
(cdep)illabout
d48f259ec7
CODEOWNERS: make sure all Haskell files are present 2021-05-03 15:14:49 +09:00
Malte Brandy
95908a23cb
CODEOWNERS: Haskell files. Add maralorn, declutter 2021-05-02 14:50:37 +02:00
sternenseemann
111151c4bc labeler: tag haskell tests as topic: haskell 2021-05-01 22:58:35 +02:00
sternenseemann
598adfc53c CODEOWNERS: notify for haskell specific tests 2021-05-01 22:58:35 +02:00
Domen Kožar
77215825de
editorconfig check: avoid channels as they might break one day 2021-04-29 10:14:40 +02:00
Domen Kožar
433df32ddb
editorconfig check: instruct user what to do 2021-04-29 10:14:40 +02:00
zowoq
5ba2e4e9c6 .github/workflows/editorconfig.yml: switch to pull_request_target
- use pull_request_target to avoid having to manually approve the action
- use nixpkgs editorconfig-checker rather than external binary
2021-04-28 23:40:50 +10:00
Graham Christensen
d6ed686eb2
Add NixOS/Security as a reviewer for .github/workflows 2021-04-24 13:21:42 -04:00
Graham Christensen
9d95ba3dd6 actions: add some permission restrictions 2021-04-24 13:07:57 -04:00
Domen Kožar
436161a2b8
Update .github/workflows/direct-push.yml
Co-authored-by: zowoq <59103226+zowoq@users.noreply.github.com>
2021-04-21 10:26:59 +02:00
Domen Kožar
932ffcd08d
Update .github/workflows/direct-push.yml
Co-authored-by: Alyssa Ross <hi@alyssa.is>
2021-04-19 14:06:54 +02:00
Domen Kožar
c9911f91ae
Add a warning comment on commits that violate https://github.com/NixOS/nixpkgs/issues/118661 2021-04-19 13:51:19 +02:00
Alyssa Ross
c6fae5690a
.github/labeler.yml: add bsd label 2021-04-18 20:39:51 +00:00
Robert Helgesson
831e64bad4
Drop maintainership for some packages 2021-04-18 09:00:18 +02:00
Mario Rodas
5fbe02ceca CODEOWNERS: add marsam to PostgreSQL packages 2021-04-07 04:20:00 +00:00
Mario Rodas
11f79e9dcd CODEOWNERS: add marsam to Ruby 2021-04-07 04:20:00 +00:00
zowoq
dd2f61d22d .github/workflows/manual-*.yml: update cachix / install-nix actions 2021-04-03 16:10:57 +10:00
zowoq
574c4a7468 .github/workflows/labels.yml: set event types
opened, synchronize, reopened are the defaults for `pull_request_target`,
`edited` will trigger the label action if the PRs base branch is changed.
2021-04-03 06:09:27 +10:00
Alyssa Ross
53f49682ee
ruby: remove myself as maintainer/CODEOWNER
It's been at least a year since I kept up to date with Ruby, and I
don't think I really have anything left to offer Nixpkgs in terms of
Ruby expertise.
2021-03-31 09:27:35 +00:00
zowoq
b83b95e37f .github/workflows/editorconfig.yml: 2.3.1 -> 2.3.5 2021-03-30 05:43:39 +10:00
Tim Steinbach
6042f10cbe
labeller: Add kernel subfolder 2021-03-26 18:55:56 -04:00
sternenseemann
f0f79f7643 codeowners: add sternenseemann for haskell
I want to get notified about haskell PRs.
2021-03-23 02:05:13 +01:00
zowoq
13e762e940 .github/labeler.yml: update paths and sort 2021-03-20 17:51:02 -07:00
zowoq
cce9a296bd .github/workflows/labels.yml: label PRs 2021-03-20 17:51:02 -07:00
Daniël de Kok
d634835fd1
CODEOWNERS: add danieldk to Rust build-support (#114111) 2021-02-23 11:13:45 -05:00
zowoq
fc3b385a4f .github/workflows/rebase.yml: rebase for multiple branches
- Error if the commenter doesn't have write access or maintainers can't edit the PR branch.

- Close and comment on PR after rebase so that actions are run when it's reopened.
  This doesn't happen currently as we're using the default github token which isn't allowed to trigger other actions.

- Disallow unwanted rebases.
  e.g. invalid branches, redundant rebases or rebasing permanent branches onto permanent branches.
2021-02-14 11:16:40 +10:00
adisbladis
35aed860a0
CODEOWNERS Add adisbladis as poetry2nix owner 2021-02-02 15:21:13 +01:00
zowoq
ac98f9973f .github/workflows/pending-set.yml: failed -> pending 2021-01-29 22:09:27 -08:00
Pavol Rusnak
90f7338112
treewide: stdenv.lib -> lib 2021-01-24 01:49:49 +01:00
Emery Hemingway
df69951fc4 CODEOWNERS: add ehmry to Dhall packages 2021-01-15 19:14:58 +01:00
Justin Humm
073ddd892e
contributing.md: Change labels for backported PRs
This is somewhat convention already and it makes keeping track of
missing backports a lot easier.
2021-01-13 12:19:19 +01:00
Maximilian Bosch
ac8122739a
Merge pull request #108839 from aszlig/autopatchelf-codeowners
codeowners: Add myself to autoPatchelfHook
2021-01-12 20:06:09 +01:00
zowoq
084fc49bf3 .github/workflows/editorconfig.yml: 2.2.0 -> 2.3.1 2021-01-10 06:55:15 +10:00
aszlig
47d1533036
codeowners: Add myself to autoPatchelfHook
I really hate the very concept of this file (the reason being that I
think "owner" implies some form of BDFL rather than just being
notified), but since there were recent[1] changes[2] in auto-patchelf.sh
which I missed it's probably a good idea to add myself there solely for
being notified, because ofborg can't seem to infer maintainer
information here.

To make indentation consistent with all the other entries in the
codeowners file, I also re-indented the other entries in the "Nixpkgs
Internals" block.

[1]: https://github.com/NixOS/nixpkgs/pull/101142
[2]: https://github.com/NixOS/nixpkgs/pull/106830

Signed-off-by: aszlig <aszlig@nix.build>
2021-01-09 10:20:51 +01:00
WORLDofPEACE
d0ce30d9f7
Merge pull request #107135 from mkg20001/cinnamon-fixup
Cinnamon Fixup
2021-01-05 16:01:27 -05:00
zowoq
376b48b604 .github/workflows/manual-{nixos,nixpkgs}.yml: fix restrict eval
needs an explicit NIX_PATH
2021-01-03 16:38:04 +10:00
zowoq
e6f00abb56 .github/workflows/rebase-staging.yml: commit -> comment 2021-01-03 10:00:07 +10:00
zowoq
9304aa0fd4 .github/workflows/rebase-staging.yml: add reaction to the comment that started the job 2021-01-03 09:48:43 +10:00
zowoq
84b57757ad .github/workflows: build NixOS/Nixpkgs manuals with PR ref, restrict-eval and sandbox 2021-01-03 09:41:42 +10:00
zowoq
32ee74c0c9 .github/workflows: add rebase-staging.yml 2020-12-29 08:44:47 +10:00
zowoq
3f73b92270 .github/workflows/editorconfig.yml: use api for list of changed files
faster than doing a full clone and using git diff
2020-12-28 17:48:26 +10:00
Maciej Krüger
ae24ec382e
codeowners: add mkg20001 to cinnamon 2020-12-18 07:52:00 +01:00
Doron Behar
e8360685cb STALE-BOT.md: Mention github not notifying
Following https://discourse.nixos.org/t/github-doesnt-notify-reviewers-commenters-after-you-force-push-changes/10394 .
2020-12-09 23:24:02 +02:00
Frederik Rietdijk
d24639b341 GH action: merge staging(-next): fix cron
It went every minute past every 6th hour, which was too often.
Now it should go on the zeroth minute every 6th hour.
2020-12-02 14:25:08 +01:00
Frederik Rietdijk
318f929047 GH Action: merge staging(-next): comment on failure
Comment on the designated issue in case of a failure.

Whoever wants to help out resolving merge conflicts can simply follow
this issue.
2020-11-29 13:19:51 +01:00
Frederik Rietdijk
24884e5aac GH Action: merge staging(-next) periodically
Automate the merging of `master` -> `staging-next` -> `staging`.

Our main development branch is `master`. Large rebuilds go to `staging`.
Periodically, `staging` is merged into `staging-next` for stabilization.
When considered sufficiently stable, `staging-next` is merged into
`master`.

As changes arrive on these branches, it is important that they're all
updated regularly with eachothers changes. This commit automates that
part.
2020-11-28 13:44:18 +01:00