It was failing with:
x86_64-w64-mingw32-ld: qprintf.o:qprintf.c:(.text+0xb9): undefined reference to `GifErrorString'
and then
install gif2rgb gifbuild giffix giftext giftool gifclrmp "/nix/store/vcik0mlp8756g2lpmzbjw3v8mhn1529i-giflib-x86_64-w64-mingw32-5.2.1/bin"
install: cannot stat 'gif2rgb': No such file or directory
- use `makeFlags` to override `PREFIX`
- change spacing and split some attributes into multiple lines for cleaner diffs and blames
- add `meta.homepage`
- format the expression
- remove unused arguments
- move `nativeBuildInputs` to more common place
These should have been in nativeBuildInputs anyways.
But it seems the docbook generation isn't needed when downloading the tarball
It didn't change the output anyways.
So if there are any docs that were supposed to be built that needs to be fixed somehow.
libungif was merged into giflib in 2006, and hasn't been updated
since. All non-broken packages still using it build fine with giflib.
See <http://giflib.sourceforge.net/history.html>.
I haven't been doing any maintenance for a long time now and not only
do I get notified, it also creates a fake impression that all these
packages had at least one maintainer when in practice they had none.
In 3605f128 I somehow forgot about the 5.1 names that now don't make
sense anymore. I can't see any evidence of _5_1 alias ever being used
or (potentially) useful; _5 might make sense, but for now I couldn't
see why add it.
5.1.5 says: Fix SF bug #113:
Heap Buffer Overflow-2 in function DGifDecompressLine()
in cgif.c. This had been assigned CVE-2018-11490.
This *probably* also fixes a minor CVE-2019-15133 #68563 (DoS only).
(I couldn't find a good reference quickly.)
The changelogs are almost only bugfixes, and ABI tracker also looks OK:
https://abi-laboratory.pro/?view=timeline&l=giflib
so I gather this is suitable for direct push to nixpkgs staging-next.
I built several reverse dependencies locally.
The following parameters are now available:
* hardeningDisable
To disable specific hardening flags
* hardeningEnable
To enable specific hardening flags
Only the cc-wrapper supports this right now, but these may be reused by
other wrappers, builders or setup hooks.
cc-wrapper supports the following flags:
* fortify
* stackprotector
* pie (disabled by default)
* pic
* strictoverflow
* format
* relro
* bindnow
