nixpkgs/nixos/modules/services/network-filesystems
Luflosi d4fcb44dcc
nixos/kubo: fix potential panic on startup
This fixes a panic of the kubo daemon which could occur under certain conditions when the daemon was starting.
It was caused by the `ipfs.service` unit not depending on the `ipfs-api.socket` and `ipfs-gateway.socket` units with `Wants=`. This allows the `ipfs.service` to be started manually or by `nixos-rebuild` without the sockets being set up before that. When that happens, the daemon won't know about these sockets and will only use what is set in `services.kubo.settings.Addresses.Gateway` and `services.kubo.settings.Addresses.API`. By default the `API` is an empty list in NixOS though. The daemon doesn't like this at all and panics on startup, see https://github.com/ipfs/kubo/issues/10056.
With this commit, starting `ipfs.service` will first set up the two sockets before starting the actual service.
Adding the `Sockets=` option implicitly adds a `Wants=` for the sockets and this is exactly what we need. See https://www.freedesktop.org/software/systemd/man/latest/systemd.service.html#Implicit%20Dependencies . This can be checked with `systemctl show ipfs.service`.

This should probably be upstreamed to the unit file in the Kubo repo.

The problem can be reproduced in the following way:
- Add `services.kubo.enable = true` to `/etc/nixos/configuration.nix`
- `sudo nixos-rebuild switch` (this may already fail, not sure why it's not deterministic for me)
- `sudo systemctl stop ipfs-api.socket`
- `sudo systemctl stop ipfs-gateway.socket`
- `sudo systemctl stop ipfs.service`
- `sudo systemctl start ipfs.service`

Fixes #248447.
2023-12-15 23:36:08 +01:00
..
litestream treewide: use mkPackageOption 2023-11-27 01:28:36 +01:00
openafs treewide: use mkPackageOption 2023-11-27 01:28:36 +01:00
orangefs
cachefilesd.nix
ceph.nix treewide: replace mkPackageOptionMD with mkPackageOption 2023-11-30 19:03:14 +01:00
davfs2.nix
diod.nix
drbd.nix drbd: fix path to drbdadm 2023-12-15 01:35:02 +05:30
eris-server.nix
glusterfs.nix
kbfs.nix
kubo.nix nixos/kubo: fix potential panic on startup 2023-12-15 23:36:08 +01:00
moosefs.nix
netatalk.nix
nfsd.nix
rsyncd.nix
samba-wsdd.nix
samba.nix treewide: use mkPackageOption 2023-11-27 01:28:36 +01:00
tahoe.nix treewide: use mkPackageOption 2023-11-27 01:28:36 +01:00
u9fs.nix
webdav-server-rs.nix
webdav.nix
xtreemfs.nix
yandex-disk.nix