Go to file
Adam Joseph c2d1d8b751 gcc: deduplicate top-level expressions
This commit deduplicates the copy-pasted gcc mess in
pkgs/top-level/all-packages.txt, replacing it with a single
expression that branches based on the chosen version.

This refactoring has exposed several bizzare behaviors in our
historical gcc expressions.  These are almost certainly a result of
people reaching back and making a change only to the version they
care about, and neglecting adjacent versions.  These oddities went
un-noticed because in copy-paste-duplicated form it is nearly
impossible to notice what has happened.

When refactored into branch-on-version form, the irregularities jump
out at you:

1. The ISL version we are using jumps *backward* from 0.14 on gcc48
   to 0.11 on gcc49, then forward again at gcc6.  If gcc49 cannot
   use isl 0.14 why is gcc48 able to?  I doubt this is right, but if
   it is there should be an explanatory comment, and I found none.

2. gcc6 bumps to isl 0.17 only if compiling for RedoxOS. This
   probably means that gcc6 is able to use isl 0.17 everywhere. If
   not, there should have been a comment explaining why RedoxOS is
   special here.

3. gcc49 on Darwin uses gccStdenv because "build fails on Darwin
   with clang"; surely if that is the case then that is true for
   gcc48 as well, no?

4. gcc49 overrides cloog to v0.18.0, but gcc48 doesn't.  Again, very
   weird, probably somebody meant to override gcc 4.9 *and all older
   versions*, not just that one particular version.

5. when cross-compiling, gcc6,7,8 override stdenv to gcc7Stdenv
   because "gcc 10 is too strict to cross compile gcc <= 8" yet this
   override was not applied to any other versions of gcc which are
   "<= 8".  It's also odd that gcc7Stdenv is used rather than
   gcc8Stdenv.

The best part about switch-on-version form is that oversights like
the above *make the code more verbose* so they stand out.  Fixing
these likely-bugs will make the code simpler and shorter.  In
copy-paste-duplicated style the opposite is true: you get shorter
code by *forgetting* to apply changes to all the versions that need
the change!  That's a very perverse incentive.

This PR does not attempt to change or fix any of these behaviors.  I
have confirmed that it does not affect eval (same drv-hash) for all
gcc versions on both x86_64-linux and x86_64-darwin.
2023-07-28 12:24:11 -07:00
.github Merge pull request #238502 from l0b0/pr-template-headings 2023-07-28 17:07:14 +02:00
doc Merge pull request #243062 from mobusoperandi/doc_watchexec 2023-07-27 16:11:18 +02:00
lib Merge pull request #244358 from tweag/lib.path.parts 2023-07-27 11:05:48 +02:00
maintainers maintainers: add khaneliman 2023-07-28 08:18:47 -03:00
nixos Merge pull request #228815 from mweinelt/gitea-runner-test 2023-07-28 19:58:45 +02:00
pkgs gcc: deduplicate top-level expressions 2023-07-28 12:24:11 -07:00
.editorconfig lib.toPlist: keep test output in external files for their tab indents 2023-03-27 19:25:52 +02:00
.git-blame-ignore-revs git-blame-ignore-revs: add large docs migrations 2023-07-03 02:28:08 +02:00
.gitattributes .gitattributes: fix typo 2023-05-01 12:30:00 +02:00
.gitignore gitignore: add emacs "swap files" 2022-10-31 18:00:22 +01:00
.mailmap mailmap: cleanup shortlog stats for nixos-22.11 release 2022-12-02 13:01:53 +01:00
.version 23.11 is Tapir 2023-05-22 21:16:04 +02:00
CONTRIBUTING.md contributing: Explain how to run common tests 2023-06-20 08:29:47 +12:00
COPYING COPYING: 2022 -> 2023 2023-01-01 13:23:08 +02:00
default.nix
flake.nix nixosModules.pkgsReadOnly: init 2023-05-10 15:55:09 +02:00
README.md readme: replace 23.11 by 23.05 for the links 2023-05-30 16:28:54 +02:00

NixOS logo NixOS logo

Contributors badge Open Collective supporters

Nixpkgs is a collection of over 80,000 software packages that can be installed with the Nix package manager. It also implements NixOS, a purely-functional Linux distribution.

Manuals

  • NixOS Manual - how to install, configure, and maintain a purely-functional Linux distribution
  • Nixpkgs Manual - contributing to Nixpkgs and using programming-language-specific Nix expressions
  • Nix Package Manager Manual - how to write Nix expressions (programs), and how to use Nix command line tools

Community

Other Project Repositories

The sources of all official Nix-related projects are in the NixOS organization on GitHub. Here are some of the main ones:

  • Nix - the purely functional package manager
  • NixOps - the tool to remotely deploy NixOS machines
  • nixos-hardware - NixOS profiles to optimize settings for different hardware
  • Nix RFCs - the formal process for making substantial changes to the community
  • NixOS homepage - the NixOS.org website
  • hydra - our continuous integration system
  • NixOS Artwork - NixOS artwork

Continuous Integration and Distribution

Nixpkgs and NixOS are built and tested by our continuous integration system, Hydra.

Artifacts successfully built with Hydra are published to cache at https://cache.nixos.org/. When successful build and test criteria are met, the Nixpkgs expressions are distributed via Nix channels.

Contributing

Nixpkgs is among the most active projects on GitHub. While thousands of open issues and pull requests might seem a lot at first, it helps consider it in the context of the scope of the project. Nixpkgs describes how to build tens of thousands of pieces of software and implements a Linux distribution. The GitHub Insights page gives a sense of the project activity.

Community contributions are always welcome through GitHub Issues and Pull Requests. When pull requests are made, our tooling automation bot, OfBorg will perform various checks to help ensure expression quality.

The Nixpkgs maintainers are people who have assigned themselves to maintain specific individual packages. We encourage people who care about a package to assign themselves as a maintainer. When a pull request is made against a package, OfBorg will notify the appropriate maintainer(s). The Nixpkgs committers are people who have been given permission to merge.

Most contributions are based on and merged into these branches:

  • master is the main branch where all small contributions go
  • staging is branched from master, changes that have a big impact on Hydra builds go to this branch
  • staging-next is branched from staging and only fixes to stabilize and security fixes with a big impact on Hydra builds should be contributed to this branch. This branch is merged into master when deemed of sufficiently high quality

For more information about contributing to the project, please visit the contributing page.

Donations

The infrastructure for NixOS and related projects is maintained by a nonprofit organization, the NixOS Foundation. To ensure the continuity and expansion of the NixOS infrastructure, we are looking for donations to our organization.

You can donate to the NixOS foundation through SEPA bank transfers or by using Open Collective:

License

Nixpkgs is licensed under the MIT License.

Note: MIT license does not apply to the packages built by Nixpkgs, merely to the files in this repository (the Nix expressions, build scripts, NixOS modules, etc.). It also might not apply to patches included in Nixpkgs, which may be derivative works of the packages to which they apply. The aforementioned artifacts are all covered by the licenses of the respective packages.