passt: Add clang-tidy Makefile target and test, take care of warnings

Most are just about style and form, but a few were actually
serious mistakes (NDP-related).

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
Stefano Brivio
2021-10-20 00:05:11 +02:00
parent 7f1e7019cb
commit 12cfa6444c
14 changed files with 172 additions and 73 deletions

View File

@@ -204,7 +204,7 @@ void pasta_start_ns(struct ctx *c)
close(fd);
fd = open("/proc/self/setgroups", O_WRONLY);
if (write(fd, "deny", sizeof("deny")))
if (write(fd, "deny", sizeof("deny")) < 0)
warn("Cannot write to setgroups in namespace");
close(fd);