colin/passt
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tap: Remove unhelpeful vnet_pre optimization from tap_send()

Browse Source 
Callers of tap_send() can optionally use a small optimization by adding
extra space for the 4 byte length header used on the qemu socket interface.
tap_ip_send() is currently the only user of this, but this is used only
for "slow path" ICMP and DHCP packets, so there's not a lot of value to
the optimization.

Worse, having the two paths here complicates the interface and makes future
cleanups difficult, so just remove it.  I have some plans to bring back the
optimization in a more general way in future, but for now it's just in the
way.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
This commit is contained in:
David Gibson
2022-10-19 11:43:51 +11:00
committed by Stefano Brivio
parent f72b63e92f
commit fb5d1c5d7d
5 changed files with 13 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
dhcp.c
View File

@@ -377,7 +377,7 @@ int dhcp(const struct ctx *c, const struct pool *p)
memcpy(eh->h_dest, eh->h_source, ETH_ALEN);
memcpy(eh->h_source, c->mac, ETH_ALEN);
if (tap_send(c, eh, len, 0) < 0)
if (tap_send(c, eh, len) < 0)
perror("DHCP: send");
return 1;