colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

video: bridge: ssd2825: convert to video bridge UCLASS

Browse Source 
Switch from PANEL_UCLASS to VIDEO_BRIDGE_UCLASS since now
its user has bridge support.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
This commit is contained in:
Svyatoslav Ryhel
2025-02-14 15:27:20 +02:00
parent b90513c852
commit 18e810e2bb
2 changed files with 10 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/video/bridge/Kconfig
View File

@@ -46,10 +46,10 @@ config VIDEO_BRIDGE_ANALOGIX_ANX6345
config VIDEO_BRIDGE_SOLOMON_SSD2825 config VIDEO_BRIDGE_SOLOMON_SSD2825
bool "Solomon SSD2825 bridge driver" bool "Solomon SSD2825 bridge driver"
depends on PANEL && DM_GPIO depends on VIDEO_BRIDGE && PANEL && DM_GPIO
select VIDEO_MIPI_DSI select VIDEO_MIPI_DSI
help help
Solomon SSD2824 SPI RGB-DSI bridge driver wrapped into panel uClass. Solomon SSD2824 SPI RGB-DSI bridge driver.
config VIDEO_BRIDGE_TOSHIBA_TC358768 config VIDEO_BRIDGE_TOSHIBA_TC358768
bool "Support Toshiba TC358768 MIPI DSI bridge" bool "Support Toshiba TC358768 MIPI DSI bridge"

22
drivers/video/bridge/ssd2825.c
View File

@@ -10,6 +10,7 @@
#include <mipi_display.h> #include <mipi_display.h>
#include <mipi_dsi.h> #include <mipi_dsi.h>
#include <backlight.h> #include <backlight.h>
#include <video_bridge.h>
#include <panel.h> #include <panel.h>
#include <spi.h> #include <spi.h>
#include <linux/delay.h> #include <linux/delay.h>
@@ -114,7 +115,6 @@ struct ssd2825_bridge_priv {
struct display_timing timing; struct display_timing timing;
struct gpio_desc power_gpio; struct gpio_desc power_gpio;
struct gpio_desc reset_gpio;
struct clk *tx_clk; struct clk *tx_clk;
@@ -343,7 +343,7 @@ static void ssd2825_setup_pll(struct udevice *dev)
ssd2825_write_register(dev, SSD2825_VC_CTRL_REG, 0x0000); ssd2825_write_register(dev, SSD2825_VC_CTRL_REG, 0x0000);
} }
static int ssd2825_bridge_enable_panel(struct udevice *dev) static int ssd2825_bridge_attach(struct udevice *dev)
{ {
struct ssd2825_bridge_priv *priv = dev_get_priv(dev); struct ssd2825_bridge_priv *priv = dev_get_priv(dev);
struct mipi_dsi_device *device = &priv->device; struct mipi_dsi_device *device = &priv->device;
@@ -407,6 +407,7 @@ static int ssd2825_bridge_panel_timings(struct udevice *dev,
static int ssd2825_bridge_hw_init(struct udevice *dev) static int ssd2825_bridge_hw_init(struct udevice *dev)
{ {
struct ssd2825_bridge_priv *priv = dev_get_priv(dev); struct ssd2825_bridge_priv *priv = dev_get_priv(dev);
struct video_bridge_priv *uc_priv = dev_get_uclass_priv(dev);
int ret; int ret;
ret = clk_prepare_enable(priv->tx_clk); ret = clk_prepare_enable(priv->tx_clk);
@@ -424,7 +425,7 @@ static int ssd2825_bridge_hw_init(struct udevice *dev)
} }
mdelay(10); mdelay(10);
ret = dm_gpio_set_value(&priv->reset_gpio, 0); ret = dm_gpio_set_value(&uc_priv->reset, 0);
if (ret) { if (ret) {
log_debug("%s: error changing reset-gpios (%d)\n", log_debug("%s: error changing reset-gpios (%d)\n",
__func__, ret); __func__, ret);
@@ -432,7 +433,7 @@ static int ssd2825_bridge_hw_init(struct udevice *dev)
} }
mdelay(10); mdelay(10);
ret = dm_gpio_set_value(&priv->reset_gpio, 1); ret = dm_gpio_set_value(&uc_priv->reset, 1);
if (ret) { if (ret) {
log_debug("%s: error changing reset-gpios (%d)\n", log_debug("%s: error changing reset-gpios (%d)\n",
__func__, ret); __func__, ret);
@@ -485,13 +486,6 @@ static int ssd2825_bridge_probe(struct udevice *dev)
return ret; return ret;
} }
ret = gpio_request_by_name(dev, "reset-gpios", 0,
&priv->reset_gpio, GPIOD_IS_OUT);
if (ret) {
log_err("could not decode reset-gpios (%d)\n", ret);
return ret;
}
/* get clk */ /* get clk */
priv->tx_clk = devm_clk_get(dev, "tx_clk"); priv->tx_clk = devm_clk_get(dev, "tx_clk");
if (IS_ERR(priv->tx_clk)) { if (IS_ERR(priv->tx_clk)) {
@@ -502,8 +496,8 @@ static int ssd2825_bridge_probe(struct udevice *dev)
return ssd2825_bridge_hw_init(dev); return ssd2825_bridge_hw_init(dev);
} }
static const struct panel_ops ssd2825_bridge_ops = { static const struct video_bridge_ops ssd2825_bridge_ops = {
.enable_backlight = ssd2825_bridge_enable_panel, .attach = ssd2825_bridge_attach,
.set_backlight = ssd2825_bridge_set_panel, .set_backlight = ssd2825_bridge_set_panel,
.get_display_timing = ssd2825_bridge_panel_timings, .get_display_timing = ssd2825_bridge_panel_timings,
}; };
@@ -515,7 +509,7 @@ static const struct udevice_id ssd2825_bridge_ids[] = {
U_BOOT_DRIVER(ssd2825) = { U_BOOT_DRIVER(ssd2825) = {
.name = "ssd2825", .name = "ssd2825",
.id = UCLASS_PANEL, .id = UCLASS_VIDEO_BRIDGE,
.of_match = ssd2825_bridge_ids, .of_match = ssd2825_bridge_ids,
.ops = &ssd2825_bridge_ops, .ops = &ssd2825_bridge_ops,
.probe = ssd2825_bridge_probe, .probe = ssd2825_bridge_probe,