colin/u-boot
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

zynq: mtd: nand: remove superfluous if

Browse Source 
This sort of code does not make much sense:

    if (ondie_ecc_enabled) {
        if (ondie_ecc_enabled) {

Remove the inner if.

The problem was indicated by cppcheck.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: Michal Simek <michal.simek@xilinx.com>
This commit is contained in:
Heinrich Schuchardt
2020-12-27 11:28:12 +01:00
committed by Michal Simek
parent 0e3a7aa7a9
commit 389b45d6b0
1 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/mtd/nand/raw/zynq_nand.c
View File

@@ -1206,12 +1206,10 @@ static int zynq_nand_probe(struct udevice *dev)
nand_chip->options |= NAND_SUBPAGE_READ; nand_chip->options |= NAND_SUBPAGE_READ;
/* On-Die ECC spare bytes offset 8 is used for ECC codes */ /* On-Die ECC spare bytes offset 8 is used for ECC codes */
if (ondie_ecc_enabled) { nand_chip->ecc.layout = &ondie_nand_oob_64;
nand_chip->ecc.layout = &ondie_nand_oob_64; /* Use the BBT pattern descriptors */
/* Use the BBT pattern descriptors */ nand_chip->bbt_td = &bbt_main_descr;
nand_chip->bbt_td = &bbt_main_descr; nand_chip->bbt_md = &bbt_mirror_descr;
nand_chip->bbt_md = &bbt_mirror_descr;
}
} else { } else {
/* Hardware ECC generates 3 bytes ECC code for each 512 bytes */ /* Hardware ECC generates 3 bytes ECC code for each 512 bytes */
nand_chip->ecc.mode = NAND_ECC_HW; nand_chip->ecc.mode = NAND_ECC_HW;